Bug 1016770
| Summary: | Review Request: nodejs-nan - Native Abstractions for Node.js | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Troy Dawson <tdawson> |
| Component: | Package Review | Assignee: | Marek Mahut <mmahut> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | jamielinux, mmahut, notting, package-review, tdawson, yohangraterol92 |
| Target Milestone: | --- | Flags: | mmahut:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | nodejs-nan-0.4.4-1.fc19 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-11-23 19:50:00 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 956806, 1016753, 1039254, 1046660 | ||
|
Description
Troy Dawson
2013-10-08 16:25:25 UTC
RPMLINT OUTPUT: $ rpmlint nodejs-nan-0.4.1-1.fc20.noarch.rpm ... typical node.js spelling warnings ... nodejs-nan.noarch: W: devel-file-in-non-devel-package /usr/lib/node_modules/nan/nan.h nodejs-nan.noarch: W: hidden-file-or-dir /usr/lib/node_modules/nan/.index.js 1 packages and 0 specfiles checked; 0 errors, 5 warnings. - nan.h needs to be in that directory, that is where it is expected. - .index.js needs to be there. node doesn't recognize nan as a module without it. Don't built :S in Mock... It built in koji, which uses mock. http://koji.fedoraproject.org/koji/taskinfo?taskID=6090200 Please be more specific about what the problem is. Troy, can you please rebase on latest 0.4.4? Thank you. Spec URL: http://tdawson.fedorapeople.org/nodejs/nodejs-nan.spec SRPM URL: http://tdawson.fedorapeople.org/nodejs/nodejs-nan-0.4.4-1.fc20.src.rpm - Updated to latest release: nan 0.4.4 Builds fine, reference build at http://koji.fedoraproject.org/koji/taskinfo?taskID=6165132 rpmlint in comment #1 are legit. This package is approved. New Package SCM Request ======================= Package Name: nodejs-nan Short Description: Native Abstractions for Node.js Owners: tdawson Branches: f18 f19 f20 el6 InitialCC: Git done (by process-git-requests). nodejs-nan-0.4.4-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/nodejs-nan-0.4.4-1.fc19 nodejs-nan-0.4.4-1.fc19 has been pushed to the Fedora 19 testing repository. nodejs-nan-0.4.4-1.fc19 has been pushed to the Fedora 19 stable repository. *** Bug 1089469 has been marked as a duplicate of this bug. *** |