Bug 1016770 - Review Request: nodejs-nan - Native Abstractions for Node.js
Review Request: nodejs-nan - Native Abstractions for Node.js
Status: CLOSED ERRATA
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Marek Mahut
Fedora Extras Quality Assurance
:
: 1089469 (view as bug list)
Depends On:
Blocks: nodejs-reviews 1016753 1039254 1046660
  Show dependency treegraph
 
Reported: 2013-10-08 12:25 EDT by Troy Dawson
Modified: 2014-04-19 15:39 EDT (History)
6 users (show)

See Also:
Fixed In Version: nodejs-nan-0.4.4-1.fc19
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2013-11-23 14:50:00 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
mmahut: fedora‑review+
limburgher: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Troy Dawson 2013-10-08 12:25:25 EDT
Spec URL: http://tdawson.fedorapeople.org/nodejs/nodejs-nan.spec
SRPM URL: http://tdawson.fedorapeople.org/nodejs/nodejs-nan-0.4.1-1.fc20.src.rpm
Description: 
A header file filled with macro and utility goodness
for making add on development for Node.js easier across
versions 0.8, 0.10 and 0.11, and eventually 0.12.

Fedora Account System Username: tdawson
Comment 1 Troy Dawson 2013-10-08 12:31:11 EDT
RPMLINT OUTPUT:
$ rpmlint nodejs-nan-0.4.1-1.fc20.noarch.rpm
... typical node.js spelling warnings ...
nodejs-nan.noarch: W: devel-file-in-non-devel-package /usr/lib/node_modules/nan/nan.h
nodejs-nan.noarch: W: hidden-file-or-dir /usr/lib/node_modules/nan/.index.js
1 packages and 0 specfiles checked; 0 errors, 5 warnings.

- nan.h needs to be in that directory, that is where it is expected.
- .index.js needs to be there. node doesn't recognize nan as a module without it.
Comment 2 Yohan Graterol 2013-10-22 20:19:44 EDT
Don't built :S in Mock...
Comment 3 Troy Dawson 2013-10-23 10:08:28 EDT
It built in koji, which uses mock.

http://koji.fedoraproject.org/koji/taskinfo?taskID=6090200

Please be more specific about what the problem is.
Comment 4 Marek Mahut 2013-11-08 08:42:27 EST
Troy, can you please rebase on latest 0.4.4? Thank you.
Comment 5 Troy Dawson 2013-11-08 15:27:11 EST
Spec URL: http://tdawson.fedorapeople.org/nodejs/nodejs-nan.spec
SRPM URL: http://tdawson.fedorapeople.org/nodejs/nodejs-nan-0.4.4-1.fc20.src.rpm

- Updated to latest release: nan 0.4.4
Comment 6 Marek Mahut 2013-11-11 10:49:27 EST
Builds fine, reference build at http://koji.fedoraproject.org/koji/taskinfo?taskID=6165132

rpmlint in comment #1 are legit. This package is approved.
Comment 7 Troy Dawson 2013-11-11 11:28:31 EST
New Package SCM Request
=======================
Package Name: nodejs-nan
Short Description: Native Abstractions for Node.js
Owners: tdawson
Branches: f18 f19 f20 el6
InitialCC:
Comment 8 Jon Ciesla 2013-11-11 12:14:40 EST
Git done (by process-git-requests).
Comment 9 Fedora Update System 2013-11-11 14:41:55 EST
nodejs-nan-0.4.4-1.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/nodejs-nan-0.4.4-1.fc19
Comment 10 Fedora Update System 2013-11-12 21:07:02 EST
nodejs-nan-0.4.4-1.fc19 has been pushed to the Fedora 19 testing repository.
Comment 11 Fedora Update System 2013-11-23 14:50:00 EST
nodejs-nan-0.4.4-1.fc19 has been pushed to the Fedora 19 stable repository.
Comment 12 Jamie Nguyen 2014-04-19 15:39:07 EDT
*** Bug 1089469 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.