Bug 1017272

Summary:	introspection.m4 file sometimes not included in widgets/src/Makefile.am
Product:	[Fedora] Fedora	Reporter:	mulhern <amulhern>
Component:	anaconda	Assignee:	David Shea <dshea>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	amulhern, anaconda-maint-list, dshea, g.kaviyarasu, jonathan, mkolman, sbueno, vanmeeuwen+fedora
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Unspecified
Whiteboard:
Fixed In Version:	anaconda-20.25-1	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-01-30 22:09:46 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description mulhern 2013-10-09 14:30:53 UTC

Description of problem:

automake error: src/Makefile.am:77: error: HAVE_INTROSPECTION does not appear in AM_CONDITIONAL

Version-Release number of selected component (if applicable):

master as of: Tue Oct 8 16:10:58 2013 +0200

How reproducible:

If introspection.m4 not found. Apparently it is not included in gobject-introspection package, but rather in gobject-introspection-devel package.

Steps to Reproduce:
1. ./autogen.sh at command line

Actual results:

automake error shown above

Expected results:

No errors

Additional info:

widgets/src/Makefile.am -includes $(INTROSPECTION_MAKEFILE) which should be widgets/m4/introspection.m4. This file was included in commit add0aeee but removed again in commit 38a1a9e3 because libtoolize is expected to provide it. It was not provided on my machine, but was once I installed gobject-introspection-devel.

Suggested fix: widgets/configure.ac check for appropriate version of gobject-introspection-devel, not gobject-introspection.

Comment 1 mulhern 2013-10-09 14:51:42 UTC

Probably including both is best.

Comment 2 David Shea 2013-10-09 15:28:30 UTC

Added a check for whether the GOBJECT_INTROSPECTION_CHECK macro expanded during the autoconf phase, so now the error looks like:

configure.ac:43: error: possibly undefined macro: GOBJECT_INTROSPECTION_CHECK
      If this token and others are legitimate, please use m4_pattern_allow.
      See the Autoconf documentation.

which is hopefully less cryptic.