| Summary: | Review Request: wondershaper(NG) - Simple network shaper | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Mosaab Alzoubi <moceap> |
| Component: | Package Review | Assignee: | Christopher Meng <i> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | i, kupo, mmahut, notting, package-review, pahan, panemade, shyschenko |
| Target Milestone: | --- | Flags: | i:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | wondershaper-1.2.1-2.el6 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-11-27 21:21:50 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Bug Depends On: | |||
| Bug Blocks: | 1015775 | ||
|
Description
Mosaab Alzoubi
2013-10-12 16:30:00 UTC
*** Bug 458379 has been marked as a duplicate of this bug. *** I'm not a current package maintainer but here's an informal review: $ rpmlint wondershaper1.2-1.fc19.noarch.rpm wondershaper.noarch: W: spelling-error Summary(en_US) shaper -> shape, sharper, shapes wondershaper.noarch: W: spelling-error %description -l en_US cablemodem -> cable modem, cable-modem, demonstrable wondershaper.noarch: E: incorrect-fsf-address /usr/share/doc/wondershaper-1.2/COPYING wondershaper.noarch: W: no-manual-page-for-binary wondershaper 1 packages and 0 specfiles checked; 1 errors, 3 warnings. $ rpmlint wondershaper.spec wondershaper.spec: W: no-%build-section 0 packages and 1 specfiles checked; 0 errors, 1 warnings. Also: %defattr(-,root,root,-) isn't needed I used "%defattr(-,root,root,-)" due to single sbin application. - To zero warnings by rpmlint. Spec URL: http://ojuba.org/oji/SPECS/wondershaper.spec SRPM URL: http://ojuba.org/oji/SRPMS/wondershaper-1.2-2.oji.fc19.src.rpm %defattr(-,root,root,-) is not needed anymore at all by any of the active dist releases, because they all include RPM >= 4.4. https://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions Ok , thank you Michael. It's done: Spec URL: http://ojuba.org/oji/SPECS/wondershaper.spec SRPM URL: http://ojuba.org/oji/SRPMS/wondershaper-1.2-3.oji.fc19.src.rpm 1. URL should be: http://sourceforge.net/projects/wondershaper/ 2. Because nothing need to be built during %build, please add a note about this: %build # Nothing to build. 3. install -Dm 755 wshaper %{buildroot}/%{_sbindir}/%{name} --> install -pDm755 wshaper %{buildroot}%{_sbindir}/%{name} 4. %files %doc ChangeLog COPYING README VERSION I don't think you need to ship VERSION file... Others are fine. ------------------- Suggestion: In function show_help of this shell script, please consider this change: function show_help { echo "Wonder Shaper 1.2" echo echo "Usage: $0 [device] clean|[upload speed in Kb/s] [download speed in Kb/s]" echo "Example: $0 eth0 20 500" echo echo "Report bugs at http://bugzilla.redhat.com/." exit } to function show_help { echo "Wonder Shaper 1.2" echo echo "Usage: $0 [device] clean|[upload speed in Kb/s] [download speed in Kb/s]" echo "Example: $0 eth0 20 500" echo echo "Report bugs at https://bugzilla.redhat.com/enter_bug.cgi?product=Fedora&version=rawhide&component=wondershaper." exit } Thanks alot Christopher, Your suggestion in 1.2.1 now. ----------- - Update to 1.2.1 . - Replace URL with main program page. - General tweaks. - Remove VERSION file from %%doc. Spec URL: http://ojuba.org/oji/SPECS/wondershaper.spec SRPM URL: http://ojuba.org/oji/SRPMS/wondershaper-1.2.1-1.oji.fc19.src.rpm PACKAGE APPROVED. Thank You Christopher. New Package SCM Request ======================= Package Name: wondershaper Short Description: Simple network shaper Owners: moceap Branches: f18 f19 f20 el5 el6 InitialCC: Git done (by process-git-requests). wondershaper-1.2.1-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/wondershaper-1.2.1-2.el6 wondershaper-1.2.1-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/wondershaper-1.2.1-2.fc18 wondershaper-1.2.1-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/wondershaper-1.2.1-2.fc19 wondershaper-1.2.1-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/wondershaper-1.2.1-2.fc20 wondershaper-1.2.1-2.el6 has been pushed to the Fedora EPEL 6 testing repository. wondershaper-1.2.1-2.el6 has been pushed to the Fedora EPEL 6 stable repository. wondershaper-1.2.1-2.fc18 has been pushed to the Fedora 18 stable repository. wondershaper-1.2.1-2.fc19 has been pushed to the Fedora 19 stable repository. wondershaper-1.2.1-2.fc20 has been pushed to the Fedora 20 stable repository. Package Change Request ====================== Package Name: wondershaper New Branches: epel7 Owners: moceap Git done (by process-git-requests). The included version 1.2.1 of wondershaper is really a problematic one, but the tool itself is quite useful and easy to operate. Could its version be updated to the latest 1.4? |