Bug 1018498 - Review Request: wondershaper(NG) - Simple network shaper
Review Request: wondershaper(NG) - Simple network shaper
Status: CLOSED ERRATA
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
unspecified Severity medium
: ---
: ---
Assigned To: Christopher Meng
Fedora Extras Quality Assurance
:
: 458379 (view as bug list)
Depends On:
Blocks: tuxcut
  Show dependency treegraph
 
Reported: 2013-10-12 12:30 EDT by Mosaab Alzoubi
Modified: 2014-10-20 07:49 EDT (History)
7 users (show)

See Also:
Fixed In Version: wondershaper-1.2.1-2.el6
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2013-11-27 16:21:50 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
i: fedora‑review+
limburgher: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Mosaab Alzoubi 2013-10-12 12:30:00 EDT
Spec URL: http://ojuba.org/oji/SPECS/wondershaper.spec
SRPM URL: http://ojuba.org/oji/SRPMS/wondershaper-1.2-1.oji.fc19.src.rpm
Description: Many cablemodem and ADSL users experience horrifying latency
while uploading or downloading. They also notice that uploading
hampers downloading greatly. The wondershaper neatly addresses
these issues, allowing users of a router with a wondershaper to
continue using SSH over a loaded link happily.

Fedora Account System Username: moceap
Comment 1 Christopher Meng 2013-10-12 14:00:58 EDT
*** Bug 458379 has been marked as a duplicate of this bug. ***
Comment 2 Johan Swensson 2013-10-16 16:00:52 EDT
I'm not a current package maintainer but here's an informal review:

$ rpmlint wondershaper1.2-1.fc19.noarch.rpm 
wondershaper.noarch: W: spelling-error Summary(en_US) shaper -> shape, sharper, shapes
wondershaper.noarch: W: spelling-error %description -l en_US cablemodem -> cable modem, cable-modem, demonstrable
wondershaper.noarch: E: incorrect-fsf-address /usr/share/doc/wondershaper-1.2/COPYING
wondershaper.noarch: W: no-manual-page-for-binary wondershaper
1 packages and 0 specfiles checked; 1 errors, 3 warnings.

$ rpmlint wondershaper.spec 
wondershaper.spec: W: no-%build-section
0 packages and 1 specfiles checked; 0 errors, 1 warnings.

Also:
%defattr(-,root,root,-) 

isn't needed
Comment 3 Mosaab Alzoubi 2013-10-18 00:23:11 EDT
I used "%defattr(-,root,root,-)" due to single sbin application.

- To zero warnings by rpmlint.

Spec URL: http://ojuba.org/oji/SPECS/wondershaper.spec
SRPM URL: http://ojuba.org/oji/SRPMS/wondershaper-1.2-2.oji.fc19.src.rpm
Comment 4 Michael Schwendt 2013-10-18 04:24:34 EDT
%defattr(-,root,root,-) is not needed anymore at all by any of the active dist releases, because they all include RPM >= 4.4.
https://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions
Comment 5 Mosaab Alzoubi 2013-10-18 08:27:14 EDT
Ok , thank you Michael. It's done:

Spec URL: http://ojuba.org/oji/SPECS/wondershaper.spec
SRPM URL: http://ojuba.org/oji/SRPMS/wondershaper-1.2-3.oji.fc19.src.rpm
Comment 6 Christopher Meng 2013-11-19 02:49:44 EST
1. URL should be:

http://sourceforge.net/projects/wondershaper/

2. Because nothing need to be built during %build, please add a note about this:

%build
# Nothing to build.

3. install -Dm 755 wshaper %{buildroot}/%{_sbindir}/%{name}

-->

install -pDm755 wshaper %{buildroot}%{_sbindir}/%{name}

4. %files
%doc ChangeLog COPYING README VERSION

I don't think you need to ship VERSION file...

Others are fine.


-------------------

Suggestion:

In function show_help of this shell script, please consider this change:

function show_help {
  echo "Wonder Shaper 1.2"
  echo
  echo "Usage: $0 [device] clean|[upload speed in Kb/s] [download speed in Kb/s]"
  echo "Example: $0 eth0 20 500"
  echo
  echo "Report bugs at http://bugzilla.redhat.com/."
  exit
}

to 

function show_help {
  echo "Wonder Shaper 1.2"
  echo
  echo "Usage: $0 [device] clean|[upload speed in Kb/s] [download speed in Kb/s]"
  echo "Example: $0 eth0 20 500"
  echo
  echo "Report bugs at https://bugzilla.redhat.com/enter_bug.cgi?product=Fedora&version=rawhide&component=wondershaper."
  exit
}
Comment 7 Mosaab Alzoubi 2013-11-19 07:05:54 EST
Thanks alot Christopher, Your suggestion in 1.2.1 now.

-----------

- Update to 1.2.1 .
- Replace URL with main program page.
- General tweaks.
- Remove VERSION file from %%doc.

Spec URL: http://ojuba.org/oji/SPECS/wondershaper.spec
SRPM URL: http://ojuba.org/oji/SRPMS/wondershaper-1.2.1-1.oji.fc19.src.rpm
Comment 8 Christopher Meng 2013-11-19 07:07:23 EST
PACKAGE APPROVED.
Comment 9 Mosaab Alzoubi 2013-11-19 07:35:51 EST
Thank You Christopher.

New Package SCM Request
=======================
Package Name: wondershaper
Short Description: Simple network shaper
Owners: moceap
Branches: f18 f19 f20 el5 el6
InitialCC:
Comment 10 Gwyn Ciesla 2013-11-19 08:03:36 EST
Git done (by process-git-requests).
Comment 11 Fedora Update System 2013-11-20 08:38:54 EST
wondershaper-1.2.1-2.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/wondershaper-1.2.1-2.el6
Comment 12 Fedora Update System 2013-11-20 08:43:29 EST
wondershaper-1.2.1-2.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/wondershaper-1.2.1-2.fc18
Comment 13 Fedora Update System 2013-11-20 08:43:44 EST
wondershaper-1.2.1-2.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/wondershaper-1.2.1-2.fc19
Comment 14 Fedora Update System 2013-11-20 08:43:55 EST
wondershaper-1.2.1-2.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/wondershaper-1.2.1-2.fc20
Comment 15 Fedora Update System 2013-11-20 12:24:58 EST
wondershaper-1.2.1-2.el6 has been pushed to the Fedora EPEL 6 testing repository.
Comment 16 Fedora Update System 2013-11-27 16:21:50 EST
wondershaper-1.2.1-2.el6 has been pushed to the Fedora EPEL 6 stable repository.
Comment 17 Fedora Update System 2013-11-29 01:56:39 EST
wondershaper-1.2.1-2.fc18 has been pushed to the Fedora 18 stable repository.
Comment 18 Fedora Update System 2013-11-29 01:58:45 EST
wondershaper-1.2.1-2.fc19 has been pushed to the Fedora 19 stable repository.
Comment 19 Fedora Update System 2013-12-13 22:00:29 EST
wondershaper-1.2.1-2.fc20 has been pushed to the Fedora 20 stable repository.
Comment 20 Mosaab Alzoubi 2014-09-16 19:35:29 EDT
Package Change Request
======================
Package Name: wondershaper
New Branches: epel7
Owners: moceap
Comment 21 Gwyn Ciesla 2014-10-20 07:49:14 EDT
Git done (by process-git-requests).

Note You need to log in before you can comment on or make changes to this bug.