Bug 1018523
| Summary: | Review Request: golang-github-coreos-go-log - A golang library for logging to systemd | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Lokesh Mandvekar <lsm5> |
| Component: | Package Review | Assignee: | Matthew Miller <mattdm> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | jkeck, lacypret, lemenkov, mattdm, notting, package-review, tdawson, vbatts |
| Target Milestone: | --- | Keywords: | Reopened |
| Target Release: | --- | Flags: | mattdm:
fedora-review+
gwync: fedora-cvs+ |
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | golang-github-coreos-go-log-0-0.7.git840af6b.el6 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-10-29 03:48:10 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1018501, 1018533 | ||
| Bug Blocks: | 1018478 | ||
|
Description
Lokesh Mandvekar
2013-10-12 22:04:09 UTC
%changelog * Sat Oct 12 2013 Lokesh Mandvekar <lsm5> 0-0.2.git840af6b - URL corrected - License corrected Spec URL: http://lsm5.fedorapeople.org/rpmbuild/SPECS/golang-github-coreos-go-log.spec SRPM URL: http://lsm5.fedorapeople.org/rpmbuild/SRPMS/golang-github-coreos-go-log-0-0.2.git840af6b.fc21.src.rpm Review passed, with the caveat that the Go packaging guidelines are draft and this package may need revision in the future. Whoops, I missed something. This should have BuildRequires: golang-bitbucket-kardianos-osext-devel Also BuildRequires: golang-github-coreos-go-systemd-devel (In reply to Matthew Miller from comment #4) > BuildRequires: golang-github-coreos-go-systemd-devel Use the import paths: BuildRequires: golang('github.com/coreos/go-systemd') with the actual import paths needed. This way it will be safe guarded for splitting out the libraries into subpackages. (In reply to Vincent Batts from comment #5) > (In reply to Matthew Miller from comment #4) > > BuildRequires: golang-github-coreos-go-systemd-devel > > Use the import paths: > > BuildRequires: golang('github.com/coreos/go-systemd') > > with the actual import paths needed. This way it will be safe guarded for > splitting out the libraries into subpackages. Sure, works for me. Can you put this in the packaging draft? https://fedoraproject.org/wiki/PackagingDrafts/Go However, there is a side-effect of doing it this way -- when looking for packages which build-require a certain library for security update, the import path will have to be used, which seems more error-prone. See the repoquery in the security section at the end of the draft... unless you can think of something more clever I think it may come down to a tradeoff of the safeguard you have in mind vs. making it easier to manage security problems.... Anyway the important note *here* is the requirement, however it is expressed. Lokesh points out that a buildrequires isn't really what's needed. What we need is a _regular_ Requires, because the dependency will need to be installed in order for anything to build against this. %changelog * Mon Oct 14 2013 Lokesh Mandvekar <lsm5> 0-0.3.git840af6b - Requires kardianos/osext and coreos/go-systemd Spec URL: http://lsm5.fedorapeople.org/rpmbuild/SPECS/golang-github-coreos-go-log.spec SRPM URL: http://lsm5.fedorapeople.org/rpmbuild/SRPMS/golang-github-coreos-go-log-0-0.3.git840af6b.fc21.src.rpm Okay, looks good. Again, may need updating as we update the Go packaging draft and get that to official status. New Package SCM Request ======================= Package Name: golang-github-coreos-go-log Short Description: A golang library for logging to systemd Owners: lsm5 Branches: f19 f20 el6 InitialCC: Git done (by process-git-requests). golang-github-coreos-go-log-0-0.5.git840af6b.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/golang-github-coreos-go-log-0-0.5.git840af6b.fc20 golang-github-coreos-go-log-0-0.5.git840af6b.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/golang-github-coreos-go-log-0-0.5.git840af6b.fc19 golang-github-coreos-go-log-0-0.5.git840af6b.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/golang-github-coreos-go-log-0-0.5.git840af6b.el6 golang-github-coreos-go-log-0-0.5.git840af6b.el6 has been pushed to the Fedora EPEL 6 testing repository. Package Change Request ====================== Package Name: golang-github-coreos-go-log InitialCC: golang-sig Done. golang-github-coreos-go-log-0-0.5.git840af6b.fc19 has been pushed to the Fedora 19 stable repository. golang-github-coreos-go-log-0-0.5.git840af6b.el6 has been pushed to the Fedora EPEL 6 stable repository. golang-github-coreos-go-log-0-0.5.git840af6b.fc20 has been pushed to the Fedora 20 stable repository. Package Change Request ====================== Package Name: golang-github-coreos-go-log New Branches: epel7 Owners: tdawson maxamillion Git done (by process-git-requests). golang-github-coreos-go-log-0-0.7.git840af6b.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/golang-github-coreos-go-log-0-0.7.git840af6b.fc20 golang-github-coreos-go-log-0-0.7.git840af6b.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/golang-github-coreos-go-log-0-0.7.git840af6b.fc21 golang-github-coreos-go-log-0-0.7.git840af6b.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/golang-github-coreos-go-log-0-0.7.git840af6b.el6 golang-github-coreos-go-log-0-0.7.git840af6b.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report. golang-github-coreos-go-log-0-0.7.git840af6b.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report. golang-github-coreos-go-log-0-0.7.git840af6b.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report. |