Spec URL: http://lsm5.fedorapeople.org/rpmbuild/SPECS/golang-bitbucket-kardianos-osext.spec SRPM URL: http://lsm5.fedorapeople.org/rpmbuild/SRPMS/golang-bitbucket-kardianos-osext-0-0.1.hg364fb577de68.fc21.src.rpm Description: Provides extra OS functions Fedora Account System Username: lsm5 Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=6053727 $ rpmlint SPECS/golang-bitbucket-kardianos-osext.spec SRPMS/golang-bitbucket-kardianos-osext-0-0.1.hg364fb577de68.fc21.src.rpm RPMS/noarch/golang-bitbucket-kardianos-osext-devel-0-0.1.hg364fb577de68.fc21.noarch.rpm SPECS/golang-bitbucket-kardianos-osext.spec:32: W: setup-not-quiet golang-bitbucket-kardianos-osext.src:32: W: setup-not-quiet 2 packages and 1 specfiles checked; 0 errors, 2 warnings.
The summary and description are kind of vague. I suggest Summary: Extensions to the standard Go os package %description devel Provides extensions to the standard Go os package, including Executable, which returns an absolute path which can be used to re-invoke the current program, and ExecutableFolder, which returns the directory containing the same. This package contains library source intended for building other packages which use these functions. --- Also, I'm not sure if you have this already, but this is a dep of coreos/go-log/log and not etcd proper.
(In reply to Matthew Miller from comment #1) > The summary and description are kind of vague. I suggest > > Summary: Extensions to the standard Go os package > > %description devel > Provides extensions to the standard Go os package, including Executable, > which returns an absolute path which can be used to re-invoke the current > program, > and ExecutableFolder, which returns the directory containing the same. > > This package contains library source intended for building other packages > which use these functions. Done. > > --- > > Also, I'm not sure if you have this already, but this is a dep of > coreos/go-log/log and not etcd proper. yup coreos/go-log has been updated with Requires: golang("bitbucket.org/kardianos/osext") %changelog * Mon Oct 14 2013 Lokesh Mandvekar <lsm5> 0-0.2.hg364fb577de68 - defattr removed - description and summary updated Spec URL: http://lsm5.fedorapeople.org/rpmbuild/SPECS/golang-bitbucket-kardianos-osext.spec SRPM URL: http://lsm5.fedorapeople.org/rpmbuild/SRPMS/golang-bitbucket-kardianos-osext-0-0.2.hg364fb577de68.fc21.src.rpm
Review passed, with the same caveat as other Go packages: this may need to be updated as the guidelines evolve beyond draft form.
%changelog * Mon Oct 14 2013 Lokesh Mandvekar <lsm5> 0-0.3.hg364fb577de68 - devel description update Spec URL: http://lsm5.fedorapeople.org/rpmbuild/SPECS/golang-bitbucket-kardianos-osext.spec SRPM URL: http://lsm5.fedorapeople.org/rpmbuild/SRPMS/golang-bitbucket-kardianos-osext-0-0.3.hg364fb577de68.fc21.src.rpm --minor description update
New Package SCM Request ======================= Package Name: golang-bitbucket-kardianos-osext Short Description: Extensions to the standard Go OS package Owners: lsm5 Branches: f19 f20 el6 InitialCC:
Git done (by process-git-requests).
golang-bitbucket-kardianos-osext-0-0.3.hg364fb577de68.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/golang-bitbucket-kardianos-osext-0-0.3.hg364fb577de68.fc20
golang-bitbucket-kardianos-osext-0-0.3.hg364fb577de68.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/golang-bitbucket-kardianos-osext-0-0.3.hg364fb577de68.fc19
golang-bitbucket-kardianos-osext-0-0.3.hg364fb577de68.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/golang-bitbucket-kardianos-osext-0-0.3.hg364fb577de68.el6
golang-bitbucket-kardianos-osext-0-0.3.hg364fb577de68.el6 has been pushed to the Fedora EPEL 6 testing repository.
Package Change Request ====================== Package Name: golang-bitbucket-kardianos-osext InitialCC: golang-sig
Done.
i'm closing this since it seems to have made into stable for f20, f19 and el6. please re-open if I got something wrong here. I hope CURRENTRELEASE is the correct flag :)
Package Change Request ====================== Package Name: golang-bitbucket-kardianos-osext New Branches: epel7 Owners: tdawson maxamillion