Bug 1018525

I haven't yet started looking at Python 3 support yet.  First in line was to move it towards libnl-3 and clean up the code a bit.  This has come quite far, but still not released yet.  Planning on a release in the not too far future.

If you have any ideas or thoughts about the complexity to add support for Python 3, I'm all ears.

It doesn't look *too* bad, actually, just some slightly ugly ifdeffing around module init:

http://docs.python.org/3/howto/cporting.html

Whenever you wanted to roll it into your normal development cycle, I'd be happy to help with testing.

I submitted a first version of the patch for python 3 compatibility:
https://lists.fedorahosted.org/pipermail/python-ethtool-devel/2013/000022.html

Hello; what is the status of this bug?

I see there was a new patchset posted on the mailing list in 2014, with no reply: https://lists.fedorahosted.org/archives/list/python-ethtool-devel%40lists.fedorahosted.org/2014/10/

Hello David,

I would like to know the status of this bug because Spacewalk project uses ethtool, and now we need it for Python 3. Do you need any help with this bug?

Re-assigning this bz to Gennadii Altukhov, as he will take over the maintenance of python-ethtool

Hello.

Is there any progress? Do you need help?

Have a nice day.
Lumir

Hello Lumir,

I will apply patches in near future. Sorry for the delay.

Upstream maintainer has pushed commits for Python 3 support and released a new version, all that remains is porting of the SPEC file.

Also the setup.py upstream needs to be modified for the new version.

Created a ticket here:
https://fedorahosted.org/python-ethtool/ticket/2

Checked the code and still a lot of changes need to be made upstream. With latest commits only the C parts of the code are python 3 compatible.

Changing to block the upstream tracker

Hello.

We did some changes in source code and now we have python-ethtool version 0.12 which should be Python 2/3 compatible.

Could you please try to build it respectively make separated subpackages for Python 2 and 3? If you need help, there is a guide for porting RPM packages [0] and/or we can help you of course.

Have a nice day.

[0] https://python-rpm-porting.readthedocs.io/en/latest/application-modules.html#

Taking over this. Just release ethtool 0.13 on PyPI and will update the package in rawhide and F26 soon. Speak against it now or never :D

Created attachment 1287378 [details]
dist-git patch

Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=20012215

I see I've used python-setuptools. Will change that to python2-setuptools.

arm failure. will resubmit.

Created attachment 1287381 [details]
dist-git patch

Working Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=20012263

Patch LGTM. Tested on mock as well and everything is working as expected under python3. No regressions noted and the respective modules import successfully under python2 and python3.

https://koji.fedoraproject.org/koji/taskinfo?taskID=20072180

python-ethtool-0.13-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-6b1e4c28dc

python-ethtool-0.13-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-6b1e4c28dc

python-ethtool-0.13-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.