| Summary: | Review Request: go-bindata - A small utility which generates Go code from any file | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Lokesh Mandvekar <lsm5> |
| Component: | Package Review | Assignee: | Matthew Miller <mattdm> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | jkeck, lacypret, lemenkov, lsm5, mattdm, notting, package-review, vbatts |
| Target Milestone: | --- | Keywords: | Reopened |
| Target Release: | --- | Flags: | mattdm:
fedora-review+
|
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | go-bindata-0-0.4.git79847ab.fc20 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-10-29 03:41:22 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Bug Depends On: | |||
| Bug Blocks: | 1018543 | ||
|
Description
Lokesh Mandvekar
2013-10-13 05:02:31 UTC
It looks like this one should be built as a binary, non-devel package providing the go-bindata tool, not the code. The above also implies that the package should be "go-bindata", not the longer import-path-based name. So, no -devel subpackage. Also, BuildRequires golang but no Requires -- the result is stand-alone. I think this should do it for the %build section: %build mkdir -p src/github.com/jteeuwen/ ln -s $(pwd) src/github.com/jteeuwen/go-bindata export GOPATH=$(pwd) go build -v -a %changelog * Mon Oct 14 2013 Lokesh Mandvekar <lsm5> 0-0.2.git79847ab - defattr removed - only go-bindata installed, no devel package Spec URL: http://lsm5.fedorapeople.org/rpmbuild/SPECS/golang-github-jteeuwen-go-bindata.spec SRPM URL: http://lsm5.fedorapeople.org/rpmbuild/SRPMS/golang-github-jteeuwen-go-bindata-0-0.1.git79847ab.fc21.src.rpm Except the package should actually be renamed to "go-bindata". :) (In reply to Matthew Miller from comment #6) > Except the package should actually be renamed to "go-bindata". :) yup :) %changelog * Mon Oct 14 2013 Lokesh Mandvekar <lsm5> 0-0.3.git79847ab - package name change to go-bindata Spec URL: http://lsm5.fedorapeople.org/rpmbuild/SPECS/go-bindata.spec SRPM URL: http://lsm5.fedorapeople.org/rpmbuild/SRPMS/go-bindata-0-0.3.git79847ab.fc21.src.rpm Looks good. As with all of the Go packages this may need to be updated as the draft packaging guidelines are developed. New Package SCM Request ======================= Package Name: go-bindata Short Description: A small utility which generates Go code from any file Owners: lsm5 Branches: f19 f20 el6 InitialCC: Git done (by process-git-requests). (In reply to Matthew Miller from comment #4) > I think this should do it for the %build section: > > > %build > > mkdir -p src/github.com/jteeuwen/ > ln -s $(pwd) src/github.com/jteeuwen/go-bindata > export GOPATH=$(pwd) > go build -v -a does this still build fine if the rpm is installed on the host that is trying to do a new build of the RPM? Is setting of GOBIN needed? or passing '-o %{buildroot}/usr/bin/go-bindata' to go build? (In reply to Vincent Batts from comment #11) > does this still build fine if the rpm is installed on the host that is > trying to do a new build of the RPM? > Is setting of GOBIN needed? or passing '-o %{buildroot}/usr/bin/go-bindata' > to go build? I'm pretty sure go-bindata just needs to be in the path. However, I see that etcd's mod/dashboard build script wants to build the binary into $PWD (not even $GOBIN!) and calls it as ./go-bindata. We should either patch or ignore that build script (which we'll have to do anyway because it's got other oddities). Let me know if I'm missing something here. (In reply to Vincent Batts from comment #11) > > does this still build fine if the rpm is installed on the host that is > trying to do a new build of the RPM? > Is setting of GOBIN needed? or passing '-o %{buildroot}/usr/bin/go-bindata' > to go build? It does build fine when already installed. I'm guessing everything else is good to go for this package (?) %changelog * Fri Oct 18 2013 Lokesh Mandvekar <lsm5> 0-0.4.git79847ab - buildrequires golang Yeah I think it's just waiting builds :) go-bindata-0-0.4.git79847ab.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/go-bindata-0-0.4.git79847ab.fc20 go-bindata-0-0.4.git79847ab.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/go-bindata-0-0.4.git79847ab.fc19 go-bindata-0-0.4.git79847ab.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/go-bindata-0-0.4.git79847ab.el6 go-bindata-0-0.4.git79847ab.fc20 has been pushed to the Fedora 20 testing repository. Package Change Request ====================== Package Name: go-bindata InitialCC: golang-sig Done. go-bindata-0-0.4.git79847ab.fc19 has been pushed to the Fedora 19 stable repository. go-bindata-0-0.4.git79847ab.el6 has been pushed to the Fedora EPEL 6 stable repository. go-bindata-0-0.4.git79847ab.fc20 has been pushed to the Fedora 20 stable repository. |