Bug 1019379
| Summary: | Remove top-level pom from dtgov-demos zip | ||
|---|---|---|---|
| Product: | [JBoss] JBoss Fuse Service Works 6 | Reporter: | Julian Coleman <jcoleman> |
| Component: | DT Governance, Examples | Assignee: | Kurt T Stam <kurt.stam> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Jiri Sedlacek <jsedlace> |
| Severity: | urgent | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 6.0.0 GA | CC: | atangrin, kurt.stam, ldimaggi, oskutka, sbunciak, soa-p-jira |
| Target Milestone: | ER6 | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | 1017764 | Environment: | |
| Last Closed: | Type: | Bug | |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1017764 | ||
| Bug Blocks: | |||
Hi Julian, I don't believe you can remove it. You still need it for common dependencies, and repository info etc. The DTGov project demos work just fine - and the only difference is that the vmon script runs over it. Assigning this back to Nick. Please let me know how I can help. Julian is correct. We utilise the dtgov-distro zip. Looking inside that, it has the demo directory with dtgov-demos-project/ dtgov-demos-switchyard/ pom.xml i.e. no src. I can reproduce the same error in community code (i.e. no vman) by attempting to build the dtgov-demos from the distribution zip. After further investigation, the real problem is that the dtgov-demos pom.xml is used at build time to create dtgov-demos.zip distribution and is also contained in that distribution. This pom is also referenced in the demos as their parent POM (so must be included in the distribution). The result is that anyone attempting to run maven against this POM after unpacking the dtgov-demos.zip sees the maven build failure (when trying to create the distribution). Solutions to this are: 1) remove the assembly of the dtgov-demos.zip from the dtgov-demos pom.xml and create a conditionally included assembly module to do this (see the SwitchYard quickstarts POM for an example) 2) move the dtgov-demos.zip creation into a separate module outside the dtgov-demos module heirarchy 1) above is probably simpler 3. How about if we simply add the assembly.xml? Seems to make the most sense to me. Resolved by modifying the top level BOM. Verified in FSW 6.0.0.ER6 (Beta). |
The top-level pom.xml should be removed from the dtgov-demos zip. Something like (untested): diff --git a/dtgov-demos/src/main/assembly/dist.xml b/dtgov-demos/src/main/assembly/dist.xml index 93814d8..d521aec 100644 --- a/dtgov-demos/src/main/assembly/dist.xml +++ b/dtgov-demos/src/main/assembly/dist.xml @@ -12,6 +12,7 @@ <fileSet> <useDefaultExcludes>true</useDefaultExcludes> <excludes> + <exclude>pom.xml</exclude> <exclude>src/</exclude> <exclude>**/.settings/**</exclude> <exclude>**/.classpath</exclude> @@ -23,4 +24,4 @@ <fileMode>0755</fileMode> </fileSet> </fileSets> -</assembly> \ No newline at end of file +</assembly>