Bug 1020669

Summary:	Enter in 'Do you want to close the session?' dialog should be equal to hitting 'OK' button
Product:	Red Hat Enterprise Linux 7	Reporter:	tingting zheng <tzheng>
Component:	virt-viewer	Assignee:	Christophe Fergeau <cfergeau>
Status:	CLOSED ERRATA	QA Contact:	Virtualization Bugs <virt-bugs>
Severity:	low	Docs Contact:
Priority:	medium
Version:	7.0	CC:	cfergeau, codong, dblechte, desktop-qa-list, djasa, dyuan, jjongsma, mzhan, rbalakri, tzheng
Target Milestone:	rc
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	virt-viewer-0.6.0-1.el7	Doc Type:	Bug Fix
Doc Text:	Cause: 'Cancel' was not designated as the default action of the dialog Consequence: Pressing 'enter' did not close the dialog Fix: Make 'Cancel' be the default action Result: Pressing the 'enter' button closes the dialog as if the user had clicked 'Cancel'	Story Points:	---
Clone Of:	1012972	Environment:
Last Closed:	2015-03-05 13:38:11 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Bug Depends On:	1012972, 1109400
Bug Blocks:

Description tingting zheng 2013-10-18 07:04:05 UTC

The bug can also be reproduced on rhel7,so cloned the bug.
+++ This bug was initially created as a clone of Bug #1012972 +++

Description of problem:
Enter key in dialogs is usually equivalent of hitting OK button. This is not the case with virt-viewer where it toggles the widget with default focus - "Do not ask me again" checkbox. The default focus is correct IMO as it allows to toggle the checkbox with a single spacebar stroke but the Enter should work as usual, not to be redunant to spacebar.

Version-Release number of selected component (if applicable):
virt-viewer-0.5.6-8
spice-gtk-0.20-9

How reproducible:
always

Steps to Reproduce:
1. connect with virt-viewer to some VM
2. File --> Exit
3. hit Enter

Actual results:
"Do not ask me again" is selected

Expected results:
virt-viewer exits

Additional info:

--- Additional comment from RHEL Product and Program Management on 2013-10-13 21:54:01 EDT ---

This request was not resolved in time for the current release.
Red Hat invites you to ask your support representative to
propose this request, if still desired, for consideration in
the next release of Red Hat Enterprise Linux.

--- Additional comment from tingting zheng on 2013-10-18 01:44:52 EDT ---

I can reproduce this bug with virt-viewer-0.5.6-8.el6.x86_64.

Comment 1 CongDong 2013-11-21 03:09:24 UTC

I can reproduce this with:
virt-viewer-0.5.7-2.el7.x86_64

Steps:
1. # virsh list --all
 Id    Name                           State
----------------------------------------------------
 2     rhel6.5                        running
# virt-viewer rhel6.5
2. File -> Quit
3. Press "Enter" key.

Result:
step2, Dialog "Do you want to close the session?" come out
step3, after press "Enter", just check on the "Do not ask me again" checkbox, the session still there.

Comment 2 Christophe Fergeau 2013-11-21 09:08:18 UTC

From parent bug:

Comment 3 Marc-Andre Lureau 2013-10-18 07:04:40 EDT

Should be addressed by https://git.fedorahosted.org/cgit/virt-viewer.git/commit/?id=697b4929ac22a1014db0b81270d1d01b51a773bf

Status: NEW → POST

Comment 4 Christophe Fergeau 2013-10-18 08:13:21 EDT

(with the caveat that this will activate Cancel by default, not Ok which I think is consistent with the intent of the dialog)

Comment 4 tingting zheng 2014-07-22 06:00:10 UTC

I can reproduce this bug with:
virt-viewer-0.5.7-7.el7.x86_64

Tested pass with:
virt-viewer-0.6.0-1.el7.x86_64

Steps:
1. connect with virt-viewer to a VM
2. File --> Exit
3. Hit Enter

Click 'Enter' key would activate Cancel,refer to comment 2.

Refer to the above comments,change the status 'VERIFIED'.

Comment 6 errata-xmlrpc 2015-03-05 13:38:11 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-0295.html