Bug 1020809

Summary:	Please simplify %perl_default_filter
Product:	[Fedora] Fedora	Reporter:	Remi Collet <fedora>
Component:	perl	Assignee:	Petr Pisar <ppisar>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	20	CC:	cweyl, iarnell, jplesnik, kasal, perl-devel, ppisar, psabata, rc040203, tcallawa
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	perl-5.18.1-289.fc21	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-10-22 11:11:34 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Remi Collet 2013-10-18 10:21:00 UTC

See : https://fedorahosted.org/fpc/ticket/353

So, the %perl_default_filter macro definition could be simplyfy

-%global __provides_exclude_from %{perl_vendorarch}/auto/.*\\\\.so$|%{perl_archlib}/.*\\\\.so$|%{_docdir}
+%global __provides_exclude_from %{_docdir}

This change will be reflected in 
https://fedoraproject.org/wiki/Packaging:AutoProvidesAndRequiresFiltering#Perl

Comment 1 Remi Collet 2013-10-18 10:21:50 UTC

To be clear "the %perl_default_filter macro definition could be simplify in Fedora >= 20"

Comment 2 Petr Pisar 2013-10-22 06:41:40 UTC

We will see. I will do some tests and in case of success, I will implement it in F21.

Comment 3 Petr Pisar 2013-10-22 07:40:58 UTC

So it seems to work.

However I would like to sanity the filters too: To anchor the expressions and to append them instead of redefining:

-%global __provides_exclude_from %{_docdir}
-%global __requires_exclude_from %{_docdir}
-%global __provides_exclude perl\\\\(VMS|perl\\\\(Win32|perl\\\\(DB\\\\)|perl\\\\(UNIVERSAL\\\\)
-%global __requires_exclude perl\\\\(VMS|perl\\\\(Win32
+%global __provides_exclude_from %{?__provides_exclude_from:%__provides_exclude_from|}^%{_docdir}
+%global __requires_exclude_from %{?__requires_exclude_from:%__requires_exclude_from|}^%{_docdir}
+%global __provides_exclude {?__provides_exclude:%__provides_exclude|}^perl\\\\(VMS|perl\\\\(Win32|perl\\\\(DB\\\\)|^perl\\\\(UNIVERSAL\\\\)
+%global __requires_exclude {?__requires_exclude:%__requires_exclude|}^perl\\\\(VMS|^perl\\\\(Win32

Comment 4 Petr Pisar 2013-10-22 08:00:35 UTC

(In reply to Petr Pisar from comment #3)
> So it seems to work.
> 
> However I would like to sanity the filters too: To anchor the expressions
> and to append them instead of redefining:
> 
Correct new values would be:

%global __provides_exclude_from %{?__provides_exclude_from:%__provides_exclude_from|}^%{_docdir}
%global __requires_exclude_from %{?__requires_exclude_from:%__requires_exclude_from|}^%{_docdir}
%global __provides_exclude %{?__provides_exclude:%__provides_exclude|}^perl\\\\(VMS|^perl\\\\(Win32|^perl\\\\(DB\\\\)|^perl\\\\(UNIVERSAL\\\\)
%global __requires_exclude %{?__requires_exclude:%__requires_exclude|}^perl\\\\(VMS|^perl\\\\(Win32

Comment 5 Petr Pisar 2013-10-22 09:22:18 UTC

(In reply to Petr Pisar from comment #3)
> However I would like to sanity the filters too: To anchor the expressions
> and to append them instead of redefining:
> 
And this works too. I'm going to push this version. I will create automated tests and package them for Fedora to have a canary.