Bug 1021016

Summary: V2CartModel#get_cartridge_from_directory fails with "Can't convert Nil to String" to ident is missing
Product: OpenShift Online Reporter: Paul Morie <pmorie>
Component: ContainersAssignee: Paul Morie <pmorie>
Status: CLOSED CURRENTRELEASE QA Contact: libra bugs <libra-bugs>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 2.xCC: bmeng
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-01-24 03:25:25 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Paul Morie 2013-10-18 19:25:15 UTC

Comment 1 Paul Morie 2013-10-21 14:47:26 UTC
Expected behavior is for a more descriptive error to be raised when the ident file is missing.

Comment 3 Meng Bo 2013-10-22 09:43:59 UTC
Checked on devenv_3927, the meaningful error was shown when upgrading gear without env OPENSHIFT_*_IDENT.



                    "Unhandled exception performing step: Cartridge Ident not found in /var/lib/openshift/52662b8d92e9752d43000010/jbosseap\n/opt/rh/ruby193/root/usr/share/gems/gems/openshift-origin-node-1.16.1/lib/openshift-origin-node/model/v2_cart_model.rb:164:in `get_cartridge_from_directory'\n/opt/rh/ruby193/root/usr/share/gems/gems/openshift-origin-node-1.16.1/lib/openshift-origin-node/model/v2_cart_model.rb:79:in `block in each_cartridge'\n/opt/rh/ruby193/root/usr/share/gems/gems/openshift-origin-node-1.16.1/lib/openshift-origin-node/model/v2_cart_model.rb:1072:in `block in process_cartridges'\n/opt/rh/ruby193/root/usr/share/gems/gems/openshift-origin-node-1.16.1/lib/openshift-origin-node/model/v2_cart_model.rb:1070:in `each'\n/opt/rh/ruby193/root/usr/share/gems/gems/openshift-origin-node-1.16.1/lib/openshift-origin-node/model/v2_cart_model.rb:1070:in `process_cartridges'\n/opt/rh/ruby193/root/usr/share/gems/gems/openshift-origin-node-1.16.1/lib/openshift-origin-node/model/v2_cart_model.rb:78:in `each_cartridge'\n/opt/rh/ruby193/root/usr/share/gems/gems/openshift-origin-node-1.16.1/lib/openshift-origin-node/model/upgrade.rb:286:in `block in compute_itinerary'\n/opt/rh/ruby193/root/usr/share/gems/gems/openshift-origin-node-1.16.1/lib/openshift-origin-node/utils/upgrade_progress.rb:32:in `step'\n/opt/rh/ruby193/root/usr/share/gems/gems/openshift-origin-node-1.16.1/lib/openshift-origin-node/model/upgrade.rb:280:in `compute_itinerary'\n/opt/rh/ruby193/root/usr/share/gems/gems/openshift-origin-node-1.16.1/lib/openshift-origin-node/model/upgrade.rb:156:in `execute'\n/opt/rh/ruby193/root/usr/libexec/mcollective/mcollective/agent/openshift.rb:243:in `upgrade_action'\n/opt/rh/ruby193/root/usr/share/ruby/mcollective/rpc/agent.rb:86:in `handlemsg'\n/opt/rh/ruby193/root/usr/share/ruby/mcollective/agents.rb:126:in `block (2 levels) in dispatch'\n/opt/rh/ruby193/root/usr/share/ruby/timeout.rb:69:in `timeout'\n/opt/rh/ruby193/root/usr/share/ruby/mcollective/agents.rb:125:in `block in dispatch'"


Move bug to verified.