Bug 1021579

Description of problem:
While making a script to remove a set of packages, I encountered a stubborn error: When performing a POST request to "/pulp/api/v2/repositories/pulp2-cleanup-test/actions/unassociate/" with message body resembling following json: 
{'criteria': 
  {'filters': 
    {'unit': 
      {'unit_id': 
        {'$in': 
          ['5b1feecc-5b48-40a6-a890-39f0bf5b3960']
        }
      }
    }
  }
}
I ran into the fact that it did not remove the package with ID 5b1feecc-5b48-40a6-a890-39f0bf5b3960; It removed ALL of the repositories packages.

After some talking to the developers I was pointed out that without a type_id specified, the filters would all be dropped, what remains was an unassociate query without filtering: resulting in every package being removed.

This is how the packages are not all being dropped any longer:
{"criteria":
  {"filters":
    {"unit":
      {"unit_id": 
        {"$in":
          ['5b1feecc-5b48-40a6-a890-39f0bf5b3960']
        }
      }
    },
     "type_ids":["rpm"]
  }
}

I do think this should be properly documented or/and should throw an error instead of just wiping out repositories. ^^


Kind regards

Vincent