Bug 1021579 - No error when criteria inside request body lack the required type_ids (when unassociating this results in an empty repository)
Summary: No error when criteria inside request body lack the required type_ids (when u...
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: Pulp
Classification: Retired
Component: API/integration
Version: 2.2
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ---
: 3.0.0
Assignee: pulp-bugs
QA Contact: pulp-qe-list
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-10-21 14:51 UTC by Vincent Van Driessche
Modified: 2015-02-28 21:59 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-02-28 21:59:27 UTC


Attachments (Terms of Use)


Links
System ID Priority Status Summary Last Updated
Pulp Redmine 379 None None None Never

Description Vincent Van Driessche 2013-10-21 14:51:03 UTC
Description of problem:
While making a script to remove a set of packages, I encountered a stubborn error: When performing a POST request to "/pulp/api/v2/repositories/pulp2-cleanup-test/actions/unassociate/" with message body resembling following json: 
{'criteria': 
  {'filters': 
    {'unit': 
      {'unit_id': 
        {'$in': 
          ['5b1feecc-5b48-40a6-a890-39f0bf5b3960']
        }
      }
    }
  }
}
I ran into the fact that it did not remove the package with ID 5b1feecc-5b48-40a6-a890-39f0bf5b3960; It removed ALL of the repositories packages.

After some talking to the developers I was pointed out that without a type_id specified, the filters would all be dropped, what remains was an unassociate query without filtering: resulting in every package being removed.

This is how the packages are not all being dropped any longer:
{"criteria":
  {"filters":
    {"unit":
      {"unit_id": 
        {"$in":
          ['5b1feecc-5b48-40a6-a890-39f0bf5b3960']
        }
      }
    },
     "type_ids":["rpm"]
  }
}

I do think this should be properly documented or/and should throw an error instead of just wiping out repositories. ^^


Kind regards

Vincent

Comment 1 Chris Duryee 2014-11-18 20:42:27 UTC
I would consider this to be an API bug, it is unexpected that all of the units are unassociated. I will document it for now but it should be fixed for Pulp 3.0.

Comment 2 Chris Duryee 2014-11-18 20:54:30 UTC
doc update: https://github.com/pulp/pulp/pull/1327

Comment 3 Chris Duryee 2014-11-20 21:28:31 UTC
docs update is merged to 2.4-release and up, changing BZ component to API/integration for the actual fix

Comment 4 amacdona@redhat.com 2015-02-26 18:50:21 UTC
This is the case for more than just this call. Many API calls that use critera to filter results have a similar issue.

Comment 5 Brian Bouterse 2015-02-28 21:59:27 UTC
Moved to https://pulp.plan.io/issues/379


Note You need to log in before you can comment on or make changes to this bug.