Bug 1021853

Summary: Display overlaps when the length of authorization note is too long.
Product: OpenShift Online Reporter: Yujie Zhang <yujzhang>
Component: WebsiteAssignee: Robb Hamilton <rhamilto>
Status: CLOSED WONTFIX QA Contact: libra bugs <libra-bugs>
Severity: low Docs Contact:
Priority: low    
Version: 2.xCC: jliggitt, sgoodwin, xtian
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-11-19 18:34:32 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
display overlaps
none
display overlaps on authorization details page
none
long note still overlaps on details page none

Description Yujie Zhang 2013-10-22 08:31:03 UTC
Created attachment 814903 [details]
display overlaps

Description of problem:

Created an authorization and add note for it like "QQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQ", and the display overlaps, details see in attachment please.

Version-Release number of selected component (if applicable):

devenv_3925

How reproducible:
always

Steps to Reproduce:
1.Create an authorization 
2.Add note with long length for the authorization
3.

Actual results:

The display overlaps when the length of note is long.

Expected results:

The display should be correct when the length of note is long.

Additional info:

Comment 1 Robb Hamilton 2013-10-22 20:04:26 UTC
Added new table class to fix bug and applied as needed, plus addtional table cleanup I discovered in the process of fixing the bug.

https://github.com/openshift/origin-server/pull/3961
https://github.com/openshift/li/pull/2024

Comment 2 openshift-github-bot 2013-10-22 23:20:31 UTC
Commit pushed to master at https://github.com/openshift/li

https://github.com/openshift/li/commit/51841201e60aa49bd4f758567fed63cccd693ce1
Bug 1021853: adding .table-fixed to address the bug and adding it to the needed tables, misc table cleanup

Comment 3 openshift-github-bot 2013-10-22 23:20:33 UTC
Commit pushed to master at https://github.com/openshift/origin-server

https://github.com/openshift/origin-server/commit/edce9b71bc6f087f71657d32c61445a46b59594a
Bug 1021853: adding .table-fixed to address the bug and adding it to the needed tables, misc table cleanup

Comment 4 Yujie Zhang 2013-10-23 05:17:00 UTC
(In reply to Robb Hamilton from comment #1)
hi Robb, tested this issue on devenv_3932, the display of long authorization note on settings page is corrected now, but the display of long note still overlaps on the authorization details page after clicking the note link on the settings page, details see in attachment, can you please also fix this? Thanks!

Comment 5 Yujie Zhang 2013-10-23 05:17:48 UTC
Created attachment 815222 [details]
display overlaps on authorization details page

Comment 6 Steve Goodwin 2013-11-13 20:33:40 UTC
I believe this bug has been fixed on the authorization details page. Please review.

Comment 7 Yujie Zhang 2013-11-14 03:16:37 UTC
(In reply to Steve Goodwin from comment #6)
Tested on devenv_4030, long authorization note still overlaps, need to wrap the long string, details see in attachment please.

Comment 8 Yujie Zhang 2013-11-14 03:17:22 UTC
Created attachment 823736 [details]
long note still overlaps on details page

Comment 9 Steve Goodwin 2013-11-19 18:34:32 UTC
This issue is unique to Firefox, where <p> within <fieldsets> aren't wrapping. To fix this would require setting the p or it's parent to a fixed width, which would cause problems at mobile resolutions. Or we could give it word-break: break-all but that could cause normal words to break incorrectly. 

Because of these issues and since it's an low severity, isolated case; the decision is to not fix.