Bug 1022062

Summary: socat: strcpy misuse in xiosetsockaddrenv_ip4()
Product: Red Hat Enterprise Linux 7 Reporter: Florian Weimer <fweimer>
Component: socatAssignee: Paul Wouters <pwouters>
Status: CLOSED CURRENTRELEASE QA Contact: BaseOS QE Security Team <qe-baseos-security>
Severity: low Docs Contact:
Priority: low    
Version: 7.0CC: gerhard, jaster, omoris
Target Milestone: rc   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: 1.7.3.1-1 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-11-13 10:59:50 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1019961, 1085024    

Description Florian Weimer 2013-10-22 15:06:11 UTC 
xiosetsockaddrenv_ip4() in xio-ip4.c calls strcopy on overlapping buffers:

      strcpy(valuebuff,
	     inet4addr_info(ntohl(sa->sin_addr.s_addr), valuebuff, valuelen));

I think it's sufficient to drop the strcpy call because inet4addr_info already does the writing.
Comment 2 Gerhard 2014-03-10 21:08:15 UTC 
Has been fixed in upstream release 1.7.2.4
Comment 5 Paul Wouters 2018-11-13 10:59:50 UTC 
This bug is addressed by ERRATA RHBA-2017:2049-03 socat bug fix update

https://errata.devel.redhat.com/advisory/26967