Bug 1022062 - socat: strcpy misuse in xiosetsockaddrenv_ip4()
Summary: socat: strcpy misuse in xiosetsockaddrenv_ip4()
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: socat
Version: 7.0
Hardware: All
OS: Linux
low
low
Target Milestone: rc
: ---
Assignee: Paul Wouters
QA Contact: BaseOS QE Security Team
URL:
Whiteboard:
Depends On:
Blocks: 1019961 1085024
TreeView+ depends on / blocked
 
Reported: 2013-10-22 15:06 UTC by Florian Weimer
Modified: 2018-11-13 10:59 UTC (History)
3 users (show)

Fixed In Version: 1.7.3.1-1
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-11-13 10:59:50 UTC
Target Upstream Version:

Attachments (Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

Description Florian Weimer 2013-10-22 15:06:11 UTC 
xiosetsockaddrenv_ip4() in xio-ip4.c calls strcopy on overlapping buffers:

      strcpy(valuebuff,
	     inet4addr_info(ntohl(sa->sin_addr.s_addr), valuebuff, valuelen));

I think it's sufficient to drop the strcpy call because inet4addr_info already does the writing.
Comment 2 Gerhard 2014-03-10 21:08:15 UTC 
Has been fixed in upstream release 1.7.2.4
Comment 5 Paul Wouters 2018-11-13 10:59:50 UTC 
This bug is addressed by ERRATA RHBA-2017:2049-03 socat bug fix update

https://errata.devel.redhat.com/advisory/26967
Note You need to log in before you can comment on or make changes to this bug.