Bug 1022273

Summary: [deploy] node.js cartridge should not stash/restore repo/node_modules if force_clean_build=true
Product: OpenShift Online Reporter: Andy Goldstein <agoldste>
Component: ContainersAssignee: Mrunal Patel <mpatel>
Status: CLOSED CURRENTRELEASE QA Contact: libra bugs <libra-bugs>
Severity: medium Docs Contact:
Priority: medium    
Version: 2.xCC: bmeng, mpatel
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-01-24 03:26:11 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Andy Goldstein 2013-10-22 21:40:40 UTC 
Description of problem: The node.js cartridge's control script stashes and restores app-root/runtime/repo/node_modules even if force_clean_build is true. It should respect force_clean_build and not stash/restore if it's true.


Version-Release number of selected component (if applicable):


How reproducible: 100%


Steps to Reproduce:
1. rhc app create myapp nodejs-0.6
2. edit package.json and add a dependency
3. git push
4. verify dependency exists in /var/lib/openshift/$uuid/app-root/runtime/repo/node_modules
5. remove dependency from package.json
6. add force_clean_build marker
7. git push

Actual results: dependency exists in /var/lib/openshift/$uuid/app-root/runtime/repo/node_modules


Expected results: dependency does NOT exist in /var/lib/openshift/$uuid/app-root/runtime/repo/node_modules


Additional info:
Comment 1 Mrunal Patel 2013-10-25 00:52:25 UTC 
https://github.com/openshift/origin-server/pull/3990
Comment 2 openshift-github-bot 2013-10-25 01:37:00 UTC 
Commit pushed to master at https://github.com/openshift/origin-server

https://github.com/openshift/origin-server/commit/c5ee63a23cf4f381e9731a665b3fd0df5f623ac5
Bug 1022273: Handle force clean build for nodejs.
Comment 3 Meng Bo 2013-10-25 12:10:14 UTC 
Checked on devenv_3944, node modules can be cleaned up when force_clean_build marker added.