Description of problem: The node.js cartridge's control script stashes and restores app-root/runtime/repo/node_modules even if force_clean_build is true. It should respect force_clean_build and not stash/restore if it's true. Version-Release number of selected component (if applicable): How reproducible: 100% Steps to Reproduce: 1. rhc app create myapp nodejs-0.6 2. edit package.json and add a dependency 3. git push 4. verify dependency exists in /var/lib/openshift/$uuid/app-root/runtime/repo/node_modules 5. remove dependency from package.json 6. add force_clean_build marker 7. git push Actual results: dependency exists in /var/lib/openshift/$uuid/app-root/runtime/repo/node_modules Expected results: dependency does NOT exist in /var/lib/openshift/$uuid/app-root/runtime/repo/node_modules Additional info:
https://github.com/openshift/origin-server/pull/3990
Commit pushed to master at https://github.com/openshift/origin-server https://github.com/openshift/origin-server/commit/c5ee63a23cf4f381e9731a665b3fd0df5f623ac5 Bug 1022273: Handle force clean build for nodejs.
Checked on devenv_3944, node modules can be cleaned up when force_clean_build marker added.