Bug 1022622

Description of problem:
Both the GUI and the CLI now have a list option/filter to list available subscriptions that have no overlap, but what does it mean to overlap?

The GUI says:
  Only show subscriptions that: have no overlap with existing subscriptions
  Tool Tip: Hide subscriptions which are active for dates currently covered

The CLI shows:
  --no-overlap          shows pools which provide products that are not
                        already covered; only used with --available


These descriptions are hard to understand and actually mean different things to me.  Technically the CLI description seems to me to be the most desirable.  I believe we want the functionality of this no-overlap function filter to exclude subscriptions that provide installed products that are not already "Subscribed".

For example, if an available subscription provides 2 products that are already installed and one of them has a fully compliant "Subscribed" status and the other does not.  Then the no-overlap filter should continue showing this subscription (Unfortunately this is broken today as demonstrated below).  If both of the subscription's provided products are installed and have a fully "Subscribed" status, then the no-overlap filter should exclude this subscription. 

I believe that the ultimate goal for applying all of the subscription list filters is to generate a list of subscription pools that will contribute to making the currently installed products fully "Subscribed".   


Version-Release number of selected component (if applicable):
[root@jsefler-7 ~]# subscription-manager version
server type: This system is currently not registered.
subscription management server: 0.8.28-1
subscription-manager: 1.10.4-1.el7
python-rhsm: 1.10.3-1.el7


How reproducible:


Steps to Reproduce:
Using candlepin deployed with TESTDATA and the following products installed...
[root@jsefler-7 ~]# ls /etc/pki/product/
37060.pem  37067.pem  37068.pem  37069.pem  37070.pem

[root@jsefler-7 ~]# subscription-manager list --installed
+-------------------------------------------+
    Installed Product Status
+-------------------------------------------+
Product Name:   Shared Storage Bits
Product ID:     37067
Version:        1.0
Arch:           ALL
Status:         Unknown
Status Details: 
Starts:         
Ends:           

Product Name:   Management Bits
Product ID:     37069
Version:        1.0
Arch:           ALL
Status:         Unknown
Status Details: 
Starts:         
Ends:           

Product Name:   Awesome OS Server Bits
Product ID:     37060
Version:        6.1
Arch:           ALL
Status:         Unknown
Status Details: 
Starts:         
Ends:           

Product Name:   Load Balancing Bits
Product ID:     37070
Version:        1.0
Arch:           ALL
Status:         Unknown
Status Details: 
Starts:         
Ends:           

Product Name:   Large File Support Bits
Product ID:     37068
Version:        1.0
Arch:           ALL
Status:         Unknown
Status Details: 
Starts:         
Ends:           

[root@jsefler-7 ~]# subscription-manager register
Username: testuser1
Password: 
Organization: admin
The system has been registered with ID: 152a475c-e141-45f2-b48d-6a05772c8c27 

[root@jsefler-7 ~]# subscription-manager auto-attach --disable
Auto-attach preference: disabled


[root@jsefler-7 ~]# subscription-manager list --avail --match-installed | grep "awesomeos-virt-4" -B2 -A10
Subscription Name: Awesome OS with up to 4 virtual guests
Provides:          Awesome OS Server Bits
SKU:               awesomeos-virt-4
Contract:          0
Pool ID:           8a9087404175311a01417531e2f40bb6
Available:         5
Suggested:         1
Service Level:     
Service Type:      
Multi-Entitlement: Yes
Ends:              09/30/2014
System Type:       Physical

[root@jsefler-7 ~]# subscription-manager attach --pool 8a9087404175311a01417531e2f40bb6
Successfully attached a subscription for: Awesome OS with up to 4 virtual guests

[root@jsefler-7 ~]# subscription-manager list --installed | egrep '(Status:|Product Name:)'
Product Name:   Shared Storage Bits
Status:         Not Subscribed
Product Name:   Management Bits
Status:         Not Subscribed
Product Name:   Awesome OS Server Bits
Status:         Subscribed
Product Name:   Load Balancing Bits
Status:         Not Subscribed
Product Name:   Large File Support Bits
Status:         Not Subscribed
 

^^ Notice that we are now "Subscribed" for one installed product but not all (as expected).

[root@jsefler-7 ~]# subscription-manager list --available --match-installed --no-overlap 
No available subscription pools to list

^^ BANG!  The --no-overlap was too agressive to be useful.  It filtered out the subscription for "Awesome OS Server Bundled" which happens to provide all of the installed products.

[root@jsefler-7 ~]# subscription-manager list --available --match-installed | egrep "Subscription Name: Awesome OS Server Bundled$" -A17
Subscription Name: Awesome OS Server Bundled
Provides:          Management Bits
                   Load Balancing Bits
                   Shared Storage Bits
                   Clustering Bits
                   Awesome OS Server Bits
                   Large File Support Bits
SKU:               awesomeos-server
Contract:          0
Pool ID:           8a9087404175311a01417531f1c414d3
Available:         5
Suggested:         1
Service Level:     Premium
Service Type:      Level 3
Multi-Entitlement: No
Ends:              09/30/2014
System Type:       Physical

[root@jsefler-7 ~]# subscription-manager attach --pool 8a9087404175311a01417531f1c414d3
Successfully attached a subscription for: Awesome OS Server Bundled

[root@jsefler-7 ~]# subscription-manager list --installed | egrep '(Status:|Product Name:)'
Product Name:   Shared Storage Bits
Status:         Subscribed
Product Name:   Management Bits
Status:         Subscribed
Product Name:   Awesome OS Server Bits
Status:         Subscribed
Product Name:   Load Balancing Bits
Status:         Subscribed
Product Name:   Large File Support Bits
Status:         Subscribed
[root@jsefler-7 ~]# subscription-manager status
+-------------------------------------------+
   System Status Details
+-------------------------------------------+
Overall Status: Current


^^ NOTICE: That after attaching this subscription (which --no-overlap too agressively filtered out), we are now fully compliant.

Because the "--no-overlap" filter is selected by default in the GUI, this filter should NOT hide subscriptions that can contribute to making the system compliant.  It should only filter out subscriptions whose provided product are not already fully "Subscribed". 


Now that the system is fully compliant, subscription-manager list --available --no-overlap --match-installed should show  "No available subscription pools to list"




Additional info:

If this bug is fixed, then these GUI strings should also be changed to say:
  Only show subscriptions that: provide products that are not already covered
  Tool Tip: Hide subscriptions whose provided products have a Subscribed status