Bug 1022644
| Summary: | Review Request: php-gliph - A graph library for PHP | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Shawn Iwinski <shawn> | ||||||
| Component: | Package Review | Assignee: | Remi Collet <fedora> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | medium | ||||||||
| Version: | rawhide | CC: | fedora, notting, package-review | ||||||
| Target Milestone: | --- | Flags: | fedora:
fedora-review+
gwync: fedora-cvs+ |
||||||
| Target Release: | --- | ||||||||
| Hardware: | All | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | php-gliph-0.1.5-1.el6 | Doc Type: | Bug Fix | ||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2013-11-12 00:37:59 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
|
Description
Shawn Iwinski
2013-10-23 17:12:49 UTC
I plan to review this "small" one before another "hude" one ;) Please add a link to https://github.com/sdboyer/gliph/issues/1 "Common licenses that require including their texts with all derivative works include ASL 2.0, EPL, BSD and MIT." So this will be a blocker. Created attachment 815836 [details]
phpci.log
phpcompatinfo version 2.24.0.
Created attachment 815838 [details]
review.txt
Generated by fedora-review 0.5.0 (920221d) last change: 2013-08-30
Command line :/usr/bin/fedora-review -b 1022644
Buildroot used: fedora-19-x86_64
Active plugins: Generic, PHP, Shell-api
Disabled plugins: Java, C/C++, Python, SugarActivity, Perl, R, Ruby
Disabled flags: EPEL5, EXARCH, DISTTAG
[!]: Requires correct, justified where necessary.
php-common => php(language)
[!]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
"Common licenses that require including their texts with all
derivative works include ASL 2.0, EPL, BSD and MIT."
=> have to wait for upstream to add this file
https://github.com/sdboyer/gliph/issues/1
=> So this will be a blocker.
As LICENSE is now part of upstream repo, you can add it
Source1: https://raw.github.com/sdboyer/gliph/php53/LICENSE
Small notice, I don't think it make sense to have a %{github_version}.
(In reply to Remi Collet from comment #5) > Small notice, I don't think it make sense to have a %{github_version}. For GitHub packages, I like to see all the GitHub information at the top vs. some at the top and some lower down in the spec. Since the version is actually the GitHub tag I like to include that at the top. (In reply to Remi Collet from comment #4) > [!]: Requires correct, justified where necessary. > php-common => php(language) I hang my head in shame :( > [!]: If the source package does not include license text(s) as a separate > file > from upstream, the packager SHOULD query upstream to include it. > > "Common licenses that require including their texts with all > derivative works include ASL 2.0, EPL, BSD and MIT." > => have to wait for upstream to add this file > https://github.com/sdboyer/gliph/issues/1 > => So this will be a blocker. > > > As LICENSE is now part of upstream repo, you can add it > Source1: https://raw.github.com/sdboyer/gliph/php53/LICENSE I hang my head in shame again :( I noticed this but didn't account for it in the spec :( I updated to the latest snapshot since it now contains the LICENSE file. Update diff: https://github.com/siwinski/rpms/commit/2a69ec1373c680577274fdc5fb24faa28ab87fd4 Spec URL: https://github.com/siwinski/rpms/blob/2a69ec1373c680577274fdc5fb24faa28ab87fd4/php-gliph.spec SRPM URL: http://siwinski.fedorapeople.org/SRPMS/php-gliph-0.1.4-1.20131024git8da23c6.fc19.src.rpm [x]: Requires correct, justified where necessary.
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
Blocker fixed.
=== APPROVED ===
THANKS for the review! New Package SCM Request ======================= Package Name: php-gliph Short Description: A graph library for PHP Owners: siwinski Branches: f19 f20 el6 InitialCC: Git done (by process-git-requests). php-gliph-0.1.5-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/php-gliph-0.1.5-1.fc20 php-gliph-0.1.5-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/php-gliph-0.1.5-1.el6 php-gliph-0.1.5-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/php-gliph-0.1.5-1.fc19 php-gliph-0.1.5-1.fc19 has been pushed to the Fedora 19 testing repository. php-gliph-0.1.5-1.fc20 has been pushed to the Fedora 20 stable repository. php-gliph-0.1.5-1.fc19 has been pushed to the Fedora 19 stable repository. php-gliph-0.1.5-1.el6 has been pushed to the Fedora EPEL 6 stable repository. |