Bug 1023771

Summary: Review Request: golang-github-goerlang-epmd - Erlang Port Mapper Daemon protocol
Product: [Fedora] Fedora Reporter: Peter Lemenkov <lemenkov>
Component: Package ReviewAssignee: Vincent Batts <vbatts>
Status: CLOSED WONTFIX QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: golang-updates, package-review, vbatts
Target Milestone: ---Flags: mario.blaettermann: fedora-review?
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-04-28 15:25:03 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1010713    
Bug Blocks: 1023776    
Attachments:
Description Flags
spec tweaks none

Description Peter Lemenkov 2013-10-27 19:06:39 UTC 
Spec URL: http://peter.fedorapeople.org/golang-github-goerlang-epmd.spec
SRPM URL: http://peter.fedorapeople.org/golang-github-goerlang-epmd-0-0.1.20130122gitceb5c1f.fc21.src.rpm
Description: Erlang Port Mapper Daemon protocol
Fedora Account System Username: peter
Comment 1 Mario Blättermann 2013-10-29 19:21:32 UTC 
Taking this for a full review.
Comment 2 Vincent Batts 2014-07-16 19:48:21 UTC 
Created attachment 918507 [details]
spec tweaks

Looks pretty good. A couple of points (and a patch to reference):
* removed a little boiler-plate, to use the golang rpm macros
* which makes a BuildRequires: golang
* preserve timestamps of copied source ( and removed the redundant -r, since -a does a recursive copy)
* Stub out for future tests. Hopefully upstream will provide *_test.go for us to check against.
* removed ownership of directories that the golang rpm owns

Lastly, I'm not opposed to the break out of the pieces of %{import_path}, just as long as we standardize on the use of %{import_path}.