Bug 1023771 - Review Request: golang-github-goerlang-epmd - Erlang Port Mapper Daemon protocol
Summary: Review Request: golang-github-goerlang-epmd - Erlang Port Mapper Daemon protocol
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Vincent Batts
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1010713
Blocks: 1023776
TreeView+ depends on / blocked
 
Reported: 2013-10-27 19:06 UTC by Peter Lemenkov
Modified: 2016-04-28 15:25 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2016-04-28 15:25:03 UTC
Type: ---
Embargoed:
mario.blaettermann: fedora-review?

Attachments (Terms of Use)
spec tweaks (1.59 KB, patch)
2014-07-16 19:48 UTC, Vincent Batts 		no flags Details | Diff
View All

Description Peter Lemenkov 2013-10-27 19:06:39 UTC 
Spec URL: http://peter.fedorapeople.org/golang-github-goerlang-epmd.spec
SRPM URL: http://peter.fedorapeople.org/golang-github-goerlang-epmd-0-0.1.20130122gitceb5c1f.fc21.src.rpm
Description: Erlang Port Mapper Daemon protocol
Fedora Account System Username: peter
Comment 1 Mario Blättermann 2013-10-29 19:21:32 UTC 
Taking this for a full review.
Comment 2 Vincent Batts 2014-07-16 19:48:21 UTC 
Created attachment 918507 [details]
spec tweaks

Looks pretty good. A couple of points (and a patch to reference):
* removed a little boiler-plate, to use the golang rpm macros
* which makes a BuildRequires: golang
* preserve timestamps of copied source ( and removed the redundant -r, since -a does a recursive copy)
* Stub out for future tests. Hopefully upstream will provide *_test.go for us to check against.
* removed ownership of directories that the golang rpm owns

Lastly, I'm not opposed to the break out of the pieces of %{import_path}, just as long as we standardize on the use of %{import_path}.
Note You need to log in before you can comment on or make changes to this bug.