Bug 1023773

Summary: Review Request: golang-github-goerlang-node - An implementation of Erlang node
Product: [Fedora] Fedora Reporter: Peter Lemenkov <lemenkov>
Component: Package ReviewAssignee: Vincent Batts <vbatts>
Status: CLOSED WONTFIX QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: golang-updates, package-review, vbatts
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-04-28 15:23:11 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1010713    
Bug Blocks: 1023776    
Attachments:
Description Flags
spec tweaks none

Description Peter Lemenkov 2013-10-27 19:08:42 UTC 
Spec URL: http://peter.fedorapeople.org/golang-github-goerlang-node.spec
SRPM URL: http://peter.fedorapeople.org/golang-github-goerlang-node-0-0.1.20130317gitf934865.fc21.src.rpm
Description: An implementation of Erlang node
Fedora Account System Username: peter
Comment 1 Vincent Batts 2014-07-21 18:57:14 UTC 
Created attachment 919734 [details]
spec tweaks

comments to accommodate the attached patch:
* remove boilerplate, and use golang provided rpm macros
* include the golang buildrequires
* include the additional golang library dependencies
* preserve timestamps in copy
* include the %check in hopes upstream provides tests
* remove already owned directories

Also, it may be beneficial for uses to include the './examples' directory. Perhaps as %doc or just in  its current path.