Bug 1023773 - Review Request: golang-github-goerlang-node - An implementation of Erlang node
Summary: Review Request: golang-github-goerlang-node - An implementation of Erlang node
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Vincent Batts
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1010713
Blocks: 1023776
TreeView+ depends on / blocked
 
Reported: 2013-10-27 19:08 UTC by Peter Lemenkov
Modified: 2016-04-28 15:23 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-04-28 15:23:11 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)
spec tweaks (2.00 KB, patch)
2014-07-21 18:57 UTC, Vincent Batts 		no flags Details | Diff
View All

Description Peter Lemenkov 2013-10-27 19:08:42 UTC 
Spec URL: http://peter.fedorapeople.org/golang-github-goerlang-node.spec
SRPM URL: http://peter.fedorapeople.org/golang-github-goerlang-node-0-0.1.20130317gitf934865.fc21.src.rpm
Description: An implementation of Erlang node
Fedora Account System Username: peter
Comment 1 Vincent Batts 2014-07-21 18:57:14 UTC 
Created attachment 919734 [details]
spec tweaks

comments to accommodate the attached patch:
* remove boilerplate, and use golang provided rpm macros
* include the golang buildrequires
* include the additional golang library dependencies
* preserve timestamps in copy
* include the %check in hopes upstream provides tests
* remove already owned directories

Also, it may be beneficial for uses to include the './examples' directory. Perhaps as %doc or just in  its current path.
Note You need to log in before you can comment on or make changes to this bug.