Bug 1023774

Summary: Review Request: golang-github-goerlang-port - Simple API to write Erlang ports in Go
Product: [Fedora] Fedora Reporter: Peter Lemenkov <lemenkov>
Component: Package ReviewAssignee: Vincent Batts <vbatts>
Status: CLOSED WONTFIX QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: golang-updates, package-review, vbatts
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-04-28 15:27:48 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1010713    
Bug Blocks: 1023776    
Attachments:
Description Flags
tweaks on spec none

Description Peter Lemenkov 2013-10-27 19:09:32 UTC 
Spec URL: http://peter.fedorapeople.org/golang-github-goerlang-port.spec
SRPM URL: http://peter.fedorapeople.org/golang-github-goerlang-port-0-0.1.20130117git45ea699.fc21.src.rpm
Description: Simple API to write Erlang ports in Go
Fedora Account System Username: peter
Comment 1 Vincent Batts 2014-07-21 18:45:32 UTC 
Created attachment 919733 [details]
tweaks on spec

a few comments to accommodate the attached patch:
* remove macro boilerplate, to use the golang provided macros
* include golang as a BuildRequires
* preserve timestamps when copying
* check the tests they provide
* don't own the directories that the golang rpm owns
Comment 2 Vincent Batts 2014-07-21 18:49:28 UTC 
also, it may be helpful to include the 'pingpong' directory. either as %doc, or just in place as a reference.