Bug 1023774 - Review Request: golang-github-goerlang-port - Simple API to write Erlang ports in Go
Summary: Review Request: golang-github-goerlang-port - Simple API to write Erlang port...
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Vincent Batts
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1010713
Blocks: 1023776
TreeView+ depends on / blocked
 
Reported: 2013-10-27 19:09 UTC by Peter Lemenkov
Modified: 2016-04-28 15:27 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2016-04-28 15:27:48 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)
tweaks on spec (1.88 KB, patch)
2014-07-21 18:45 UTC, Vincent Batts 		no flags Details | Diff
View All

Description Peter Lemenkov 2013-10-27 19:09:32 UTC 
Spec URL: http://peter.fedorapeople.org/golang-github-goerlang-port.spec
SRPM URL: http://peter.fedorapeople.org/golang-github-goerlang-port-0-0.1.20130117git45ea699.fc21.src.rpm
Description: Simple API to write Erlang ports in Go
Fedora Account System Username: peter
Comment 1 Vincent Batts 2014-07-21 18:45:32 UTC 
Created attachment 919733 [details]
tweaks on spec

a few comments to accommodate the attached patch:
* remove macro boilerplate, to use the golang provided macros
* include golang as a BuildRequires
* preserve timestamps when copying
* check the tests they provide
* don't own the directories that the golang rpm owns
Comment 2 Vincent Batts 2014-07-21 18:49:28 UTC 
also, it may be helpful to include the 'pingpong' directory. either as %doc, or just in place as a reference.
Note You need to log in before you can comment on or make changes to this bug.