Bug 1026826

Summary: openshift_facts.rb should not be installed in %{vendor_ruby}facter
Product: OKD Reporter: Andy Grimm <agrimm>
Component: ContainersAssignee: Abhishek Gupta <abhgupta>
Status: CLOSED WONTFIX QA Contact: libra bugs <libra-bugs>
Severity: medium Docs Contact:
Priority: medium    
Version: 2.xCC: jgoulding, rthrashe
Target Milestone: ---Keywords: UpcomingRelease
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-02-02 21:42:49 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1277547    

Description Andy Grimm 2013-11-05 13:52:52 UTC 
The best practice for add-on facter modules is to put them in a separate directory from the facter installation itself, and to use RUBYLIB, LOAD_PATH, or FACTERLIB to load them (as mentioned in http://docs.puppetlabs.com/guides/custom_facts.html ).  The current placement does not allow for openshift_facts to be omitted or overridden, and it is critical for OpenShift Online to do so.  

More context on this: the reason this has come up is that openshift_facts duplicates the data collection done by one of our other cron jobs, but it only stores counts and throws away the actual mappings of gear uuid / uid / state that we need for our monitoring system.  Collecting this data multiple times is very expensive on a busy system.  We would prefer it if such a metadata cache were part of the core node codebase, but since it is not, we need to keep our own cache implementation for now.
Comment 1 Rory Thrasher 2016-02-02 22:18:48 UTC 
Closed WONTFIX due to discussion with Andy Grimm on priority.