Bug 1026826 - openshift_facts.rb should not be installed in %{vendor_ruby}facter
Summary: openshift_facts.rb should not be installed in %{vendor_ruby}facter
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: OKD
Classification: Red Hat
Component: Containers
Version: 2.x
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ---
: ---
Assignee: Abhishek Gupta
QA Contact: libra bugs
URL:
Whiteboard:
Depends On:
Blocks: 1277547
TreeView+ depends on / blocked
 
Reported: 2013-11-05 13:52 UTC by Andy Grimm
Modified: 2016-11-08 03:48 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-02-02 21:42:49 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Andy Grimm 2013-11-05 13:52:52 UTC
The best practice for add-on facter modules is to put them in a separate directory from the facter installation itself, and to use RUBYLIB, LOAD_PATH, or FACTERLIB to load them (as mentioned in http://docs.puppetlabs.com/guides/custom_facts.html ).  The current placement does not allow for openshift_facts to be omitted or overridden, and it is critical for OpenShift Online to do so.  

More context on this: the reason this has come up is that openshift_facts duplicates the data collection done by one of our other cron jobs, but it only stores counts and throws away the actual mappings of gear uuid / uid / state that we need for our monitoring system.  Collecting this data multiple times is very expensive on a busy system.  We would prefer it if such a metadata cache were part of the core node codebase, but since it is not, we need to keep our own cache implementation for now.

Comment 1 Rory Thrasher 2016-02-02 22:18:48 UTC
Closed WONTFIX due to discussion with Andy Grimm on priority.


Note You need to log in before you can comment on or make changes to this bug.