Bug 1028139

Summary:	Metric Availability auto-refresh calls are not being cleaned up properly (and grow)
Product:	[JBoss] JBoss Operations Network	Reporter:	Mike Thompson <mithomps>
Component:	Monitoring -- Other	Assignee:	Mike Thompson <mithomps>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Mike Foley <mfoley>
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	JON 3.2	CC:	fbrychta, hrupp
Target Milestone:	ER07
Target Release:	JON 3.2.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:		Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Mike Thompson 2013-11-07 18:22:39 UTC

Description of problem:
Availability calls increase due to the number of resources clicked in the resource tree.

The additional of state (to remember open charts) to the view keeps the browser GC from cleaning up the multiple threads. When we change resources and create a new view, there is still a link the momento object that stores the opened charts and that linkage keeps the view from being GC'd. Without the link, the view is GC'd normally and the auto-refresh activity associated with the view is destroyed with view. But when the view is not destroyed and new ones are created each on has an auto-refresh associated with it.

For instance, clicking on 10 different resources leaves 10 auto-refresh threads.

Version-Release number of selected component (if applicable): 3.2.0 ER05


How reproducible:
always


Steps to Reproduce:
1. Go to Monitoring --> Metrics tab
2. click in the resource tree to change resources
3. Go to firebug or browser console and examine how many times availability is called

Actual results:
Availability calls should not increase with changing resource links


Expected results:
Should only have 1 availability call no matter what


Additional info:
Workaround: refresh the browser

Comment 1 Mike Thompson 2013-11-07 18:25:27 UTC

I had this fix in my branch mtho11/bz1014571 but that didn't make it in due to stability issues. So I'm extracting the relevant bits to place into master now.

Comment 2 Mike Thompson 2013-11-07 18:49:46 UTC

Created factory methods for view creation that ensures singleton instance.

Committed to master: cee05ed

Comment 3 Mike Thompson 2013-11-07 20:04:57 UTC

Committed to release/jon3.2.x as commit: 2c51610

Comment 4 Mike Thompson 2013-11-08 20:43:39 UTC

Additional changes as I found it was not complete. Also removed some of the overly verbose logging to the browser console.

commit to master: e0cbede
commit to release/jon3.2.x: 979b91a

Comment 5 Simeon Pinder 2013-11-19 15:48:58 UTC

Moving to ON_QA as available for testing with new brew build.

Comment 6 Simeon Pinder 2013-11-22 05:14:24 UTC

Mass moving all of these from ER6 to target milestone ER07 since the ER6 build was bad and QE was halted for the same reason.

Comment 7 Filip Brychta 2013-12-02 09:47:11 UTC

Verified on
Version :	
3.2.0.ER7
Build Number :	
e8e6401:ff0061d