Bug 1028765

Summary: [RFE] Display canDoAction messages from commands executed during the flow after the initial canDoAction checks succeeded
Product: Red Hat Enterprise Virtualization Manager Reporter: Elad <ebenahar>
Component: ovirt-engine-webadmin-portalAssignee: Ravi Nori <rnori>
Status: CLOSED WONTFIX QA Contact: Pavel Stehlik <pstehlik>
Severity: high Docs Contact:
Priority: unspecified    
Version: 3.3.0CC: acanan, amureini, ecohen, iheim, laravot, masayag, oourfali, rbalakri, Rhev-m-bugs, scohen, sherold, yeylon
Target Milestone: ---Keywords: FutureFeature
Target Release: ---Flags: scohen: Triaged+
Hardware: x86_64   
OS: Unspecified   
Whiteboard: infra
Fixed In Version: Doc Type: Enhancement
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-11-12 11:35:51 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Infra RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
Description Flags
engine.log and screenshot none

Description Elad 2013-11-10 15:07:11 UTC
Created attachment 822090 [details]
engine.log and screenshot

Description of problem:
When live storage migration fails because another operation was managed to take a lock on the disk, user don't get any error about the failure.
Happened to me when during LSM, I tried to attach the disk snapshot to another VM with REST (as part of the new backup-API feature) 

Version-Release number of selected component (if applicable):

How reproducible:

Steps to Reproduce:
On a block/file pool with 2 SDs:
1. create 2 VMs with disk and run them 
2. live migrate one of the VMs disk to the second SD
3. during the LSM operation (right after it began), attach the disk snapshot (the one that is simultaneously  migrating) to the other running vm using REST

Actual results:
The disk attachment operation succeeds and LSM fails.

LSM is failing with a CanDoAction:

2013-11-10 15:56:12,613 WARN  [org.ovirt.engine.core.bll.lsm.LiveMigrateVmDisksCommand] (ajp-/ [47722e08] CanDoAction of action LiveMigrateVmDisks failed. Reasons:VAR__ACTION__MOVE,VAR__TYPE__VM_D

User don't get any notification about the LSM failure 

Expected results:
Engine should report about the failure on UI.

Additional info: engine.log and screenshot

Comment 1 Liron Aravot 2013-11-25 16:43:45 UTC
The main issue is that after the command execution has started, CDA messages from called commands during the execution flow (including LSM) won't be displayed as the command is already being executed.

The issue specifically in that bug was resolved by the given patch as the taken locks were removed from LiveMigrateDiskCommand (for other CDA messages there will be an audit log).

Therefore i'm changing this to a RFE of displaying CDA messages from commands executed after initial CDA checks were done.

Comment 3 Itamar Heim 2014-01-23 17:58:38 UTC
is this done or not? the only associated patch to this bug is merged?

Comment 4 Liron Aravot 2014-01-27 09:47:44 UTC
Not done, the provided patch solves the bug - but doesn't implplement the RFE related to it.

Comment 9 Moti Asayag 2015-11-12 11:35:51 UTC
Bug is closed due to a missing use case. Also I'd avoid auto-logging messages to the audit log which has no audit-log-type since this bypass the audit-log messages flooding mechanism.