Bug 1028809

Spec URL: http://dtardon.fedorapeople.org/rpm/libe-book.spec
SRPM URL: http://dtardon.fedorapeople.org/rpm/libe-book-0.0.1-2.fc19.src.rpm

Hi David.

Another review swap ? 
https://bugzilla.redhat.com/show_bug.cgi?id=1028741 ;)

Package approved !

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "GPL (v2 or later)", "Unknown or generated". 135 files have unknown
     license. Detailed output of licensecheck in /home/sagitter/1028809-libe-
     book/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown must
     be documented in the spec.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 92160 bytes in 6 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in libe-book-
     doc
[ ]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Scriptlets must be sane, if used.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Uses parallel make %{?_smp_mflags} macro.
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: SourceX tarball generation or download is documented.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package is
     arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: libe-book-0.0.1-2.fc21.x86_64.rpm
          libe-book-devel-0.0.1-2.fc21.x86_64.rpm
          libe-book-doc-0.0.1-2.fc21.noarch.rpm
          libe-book-tools-0.0.1-2.fc21.x86_64.rpm
          libe-book-0.0.1-2.fc21.src.rpm
libe-book.x86_64: W: spelling-error Summary(en_US) reflowable -> allowable
libe-book.x86_64: W: spelling-error %description -l en_US reflowable -> allowable
libe-book.x86_64: W: spelling-error %description -l en_US eBook -> e Book, book
libe-book.x86_64: W: spelling-error %description -l en_US eReader -> e Reader, reader, reread
libe-book.x86_64: W: spelling-error %description -l en_US zTXT 
libe-book-tools.x86_64: W: no-documentation
libe-book-tools.x86_64: W: no-manual-page-for-binary ebook2raw
libe-book-tools.x86_64: W: no-manual-page-for-binary ebook2html
libe-book-tools.x86_64: W: no-manual-page-for-binary ebook2text
libe-book.src: W: spelling-error Summary(en_US) reflowable -> allowable
libe-book.src: W: spelling-error %description -l en_US reflowable -> allowable
libe-book.src: W: spelling-error %description -l en_US eBook -> e Book, book
libe-book.src: W: spelling-error %description -l en_US eReader -> e Reader, reader, reread
libe-book.src: W: spelling-error %description -l en_US zTXT 
5 packages and 0 specfiles checked; 0 errors, 14 warnings.




Rpmlint (installed packages)
----------------------------
# rpmlint libe-book-doc libe-book-tools libe-book libe-book-devel
libe-book-tools.x86_64: W: no-documentation
libe-book-tools.x86_64: W: no-manual-page-for-binary ebook2raw
libe-book-tools.x86_64: W: no-manual-page-for-binary ebook2html
libe-book-tools.x86_64: W: no-manual-page-for-binary ebook2text
libe-book.x86_64: W: spelling-error Summary(en_US) reflowable -> allowable
libe-book.x86_64: W: spelling-error %description -l en_US reflowable -> allowable
libe-book.x86_64: W: spelling-error %description -l en_US eBook -> e Book, book
libe-book.x86_64: W: spelling-error %description -l en_US eReader -> e Reader, reader, reread
libe-book.x86_64: W: spelling-error %description -l en_US zTXT 
libe-book.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libe-book-0.0.so.0.0.1 /lib64/libwpd-stream-0.9.so.9
libe-book.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libe-book-0.0.so.0.0.1 /lib64/libicudata.so.50
4 packages and 0 specfiles checked; 0 errors, 11 warnings.
# echo 'rpmlint-done:'



Requires
--------
libe-book-doc (rpmlib, GLIBC filtered):

libe-book-tools (rpmlib, GLIBC filtered):
    libc.so.6()(64bit)
    libe-book(x86-64)
    libe-book-0.0.so.0()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libicudata.so.50()(64bit)
    libicui18n.so.50()(64bit)
    libicuuc.so.50()(64bit)
    libm.so.6()(64bit)
    libpthread.so.0()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    libwpd-0.9.so.9()(64bit)
    libwpd-stream-0.9.so.9()(64bit)
    libxml2.so.2()(64bit)
    libz.so.1()(64bit)
    rtld(GNU_HASH)

libe-book (rpmlib, GLIBC filtered):
    /sbin/ldconfig
    libc.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libicudata.so.50()(64bit)
    libicui18n.so.50()(64bit)
    libicuuc.so.50()(64bit)
    libm.so.6()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    libwpd-0.9.so.9()(64bit)
    libwpd-stream-0.9.so.9()(64bit)
    libxml2.so.2()(64bit)
    libxml2.so.2(LIBXML2_2.4.30)(64bit)
    libxml2.so.2(LIBXML2_2.5.0)(64bit)
    libxml2.so.2(LIBXML2_2.6.0)(64bit)
    libz.so.1()(64bit)
    rtld(GNU_HASH)

libe-book-devel (rpmlib, GLIBC filtered):
    /usr/bin/pkg-config
    libe-book(x86-64)
    libe-book-0.0.so.0()(64bit)
    pkgconfig(libwpd-0.9)
    pkgconfig(libwpd-stream-0.9)



Provides
--------
libe-book-doc:
    libe-book-doc

libe-book-tools:
    libe-book-tools
    libe-book-tools(x86-64)

libe-book:
    libe-book
    libe-book(x86-64)
    libe-book-0.0.so.0()(64bit)

libe-book-devel:
    libe-book-devel
    libe-book-devel(x86-64)
    pkgconfig(libe-book-0.0)



Source checksums
----------------
http://downloads.sourceforge.net/libebook/libe-book-0.0.1.tar.xz :
  CHECKSUM(SHA256) this package     : aa7ff91224648e4cb8500ac3855375bec64b914d43c981697cf18e29e344f58e
  CHECKSUM(SHA256) upstream package : aa7ff91224648e4cb8500ac3855375bec64b914d43c981697cf18e29e344f58e


Generated by fedora-review 0.5.0 (920221d) last change: 2013-08-30
Command line :/bin/fedora-review -m fedora-rawhide-x86_64 -b 1028809
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api, C/C++
Disabled plugins: Java, Python, SugarActivity, Perl, R, PHP, Ruby
Disabled flags: EPEL5, EXARCH, DISTTAG

New Package SCM Request
=======================
Package Name: libe-book
Short Description: A library for import of non-HTML reflowable e-book formats
Owners: dtardon caolanm
Branches: 
InitialCC:

Git done (by process-git-requests).

Package Change Request
======================
Package Name: libabw
New Branches: f20
Owners: dtardon caolanm

We need this as a dependency for libreoffice 4.2.

Git done (by process-git-requests).

Package Change Request
======================
Package Name: libe-book
New Branches: f20
Owners: dtardon caolanm

We need this as a dependency for libreoffice 4.2.

Git done (by process-git-requests).