Bug 1029371
| Summary: | Review Request: perl-UDDI-Lite - Library for UDDI clients in Perl | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Petr Šabata <psabata> |
| Component: | Package Review | Assignee: | Petr Pisar <ppisar> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, ppisar |
| Target Milestone: | --- | Flags: | ppisar:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | perl-UDDI-Lite-0.718-1.fc21 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-02-05 12:46:37 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 989982 | ||
| Bug Blocks: | |||
|
Description
Petr Šabata
2013-11-12 09:54:16 UTC
URL is usable. Ok.
Source0 is usable. Ok.
Source tar ball is original (SHA-256: e4998c177cd6fe97e0ed4340b7b3f832c67e2ecf1ff72f699920f2542da628e0). Ok.
Summary verified from lib/UDDI/Lite.pm. Ok.
Description verified from lib/UDDI/Lite.pm. Ok.
License verified from README, and lib/UDDI/Lite.pm. Ok.
No XS code, noarch BuildArch is Ok.
TODO: Build-require `perl(overload)' (lib/UDDI/Lite.pm:732).
All tests are skipped because they require the Internet. Ok.
$ rpmlint perl-UDDI-Lite.spec ../SRPMS/perl-UDDI-Lite-0.718-1.fc21.src.rpm ../RPMS/noarch/perl-UDDI-Lite-0.718-1.fc21.noarch.rpm
perl-UDDI-Lite.noarch: E: wrong-script-interpreter /usr/share/doc/perl-UDDI-Lite/examples/syntax1.pl perl
perl-UDDI-Lite.noarch: E: wrong-script-interpreter /usr/share/doc/perl-UDDI-Lite/examples/publish1.pl perl
perl-UDDI-Lite.noarch: E: wrong-script-interpreter /usr/share/doc/perl-UDDI-Lite/examples/inquire1.pl perl
perl-UDDI-Lite.noarch: E: wrong-script-interpreter /usr/share/doc/perl-UDDI-Lite/examples/syntax2.pl perl
perl-UDDI-Lite.noarch: E: wrong-script-interpreter /usr/share/doc/perl-UDDI-Lite/examples/simple2.pl perl
perl-UDDI-Lite.noarch: E: wrong-script-interpreter /usr/share/doc/perl-UDDI-Lite/examples/simple1.pl perl
perl-UDDI-Lite.noarch: E: wrong-script-interpreter /usr/share/doc/perl-UDDI-Lite/examples/syntax3.pl perl
2 packages and 1 specfiles checked; 7 errors, 0 warnings.
TODO: Correct shebang or mode of the examples files.
$ rpm -q -lv -p ../RPMS/noarch/perl-UDDI-Lite-0.718-1.fc21.noarch.rpm
drwxr-xr-x 2 root root 0 Nov 12 13:09 /usr/share/doc/perl-UDDI-Lite
-rw-r--r-- 1 root root 177 May 18 06:58 /usr/share/doc/perl-UDDI-Lite/Changes
-rw-r--r-- 1 root root 10266 May 16 2013 /usr/share/doc/perl-UDDI-Lite/README
drwxr-xr-x 2 root root 0 Nov 12 13:09 /usr/share/doc/perl-UDDI-Lite/examples
-rw-r--r-- 1 root root 932 May 16 2013 /usr/share/doc/perl-UDDI-Lite/examples/inquire1.pl
-rw-r--r-- 1 root root 1142 May 16 2013 /usr/share/doc/perl-UDDI-Lite/examples/publish1.pl
-rw-r--r-- 1 root root 427 May 16 2013 /usr/share/doc/perl-UDDI-Lite/examples/simple1.pl
-rw-r--r-- 1 root root 357 May 16 2013 /usr/share/doc/perl-UDDI-Lite/examples/simple2.pl
-rw-r--r-- 1 root root 978 May 16 2013 /usr/share/doc/perl-UDDI-Lite/examples/syntax1.pl
-rw-r--r-- 1 root root 1907 May 16 2013 /usr/share/doc/perl-UDDI-Lite/examples/syntax2.pl
-rw-r--r-- 1 root root 1351 May 16 2013 /usr/share/doc/perl-UDDI-Lite/examples/syntax3.pl
-rw-r--r-- 1 root root 5526 Nov 12 13:09 /usr/share/man/man3/UDDI::Lite.3pm.gz
drwxr-xr-x 2 root root 0 Nov 12 13:09 /usr/share/perl5/vendor_perl/UDDI
-rw-r--r-- 1 root root 58435 May 18 06:58 /usr/share/perl5/vendor_perl/UDDI/Lite.pm
File layout and permissions are Ok.
$ rpm -q --requires -p ../RPMS/noarch/perl-UDDI-Lite-0.718-1.fc21.noarch.rpm | sort -i | uniq -c
1 perl >= 0:5.006
1 perl(:MODULE_COMPAT_5.18.1)
1 perl(Carp)
1 perl(Exporter)
1 perl(SOAP::Lite)
1 perl(SOAP::Lite) >= 0.716
1 perl(overload)
1 perl(strict)
1 perl(vars)
1 rpmlib(CompressedFileNames) <= 3.0.4-1
1 rpmlib(FileDigests) <= 4.6.0-1
1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
1 rpmlib(PayloadIsXz) <= 5.2-1
TODO: Filter unversioned `perl(SOAP::Lite)'.
$ rpm -q --provides -p ../RPMS/noarch/perl-UDDI-Lite-0.718-1.fc21.noarch.rpm | sort -i | uniq -c
1 perl(UDDI::Constants) = 0.718
1 perl(UDDI::Data) = 0.718
1 perl(UDDI::Deserializer) = 0.718
1 perl(UDDI::Lite) = 0.718
1 perl(UDDI::SOM) = 0.718
1 perl(UDDI::Serializer) = 0.718
1 perl-UDDI-Lite = 0.718-1.fc21
Binary provides are Ok.
$ resolvedeps f21-build ../RPMS/noarch/perl-UDDI-Lite-0.718-1.fc21.noarch.rpm
Binary dependencies resolvable. Ok.
Package builds in F21 (http://koji.fedoraproject.org/koji/taskinfo?taskID=6169123). Ok.
Package is in line with Perl and Fedora packaging guidelines.
Please consider fixing all `TODO' items before building the package.
Resolution: Package APPROVED.
Thank you for the review. The unversioned dependency is actually a mistake in the filter currently in place :) I'll fix those before building the package. New Package SCM Request ======================= Package Name: perl-UDDI-Lite Short Description: Library for UDDI clients in Perl Owners: psabata jplesnik ppisar Branches: InitialCC: perl-sig Git done (by process-git-requests). |