Bug 1030747

Summary: /etc/init.d/vncserver fails if user's shell is csh
Product: Red Hat Enterprise Linux 6 Reporter: John Hein <txn2tahx3v>
Component: tigervncAssignee: Tim Waugh <twaugh>
Status: CLOSED DUPLICATE QA Contact: qe-baseos-daemons
Severity: medium Docs Contact:
Priority: unspecified    
Version: 6.4CC: txn2tahx3v
Target Milestone: rc   
Target Release: ---   
Hardware: All   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-11-18 12:34:41 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
let vncserver fail if there is a missing passwd file none

Description John Hein 2013-11-15 04:16:13 UTC 
Description of problem:

/etc/init.d/vncserver calls runuser with a command that fails when the user's shell is csh (because of syntax:  if [ -r .vnc/passwd ]; then ... fi).

Version-Release number of selected component (if applicable):

tigervnc-server-1.1.0-5.el6_4.1.i686


How reproducible:

Always.

Steps to Reproduce:
1.  Put entries in /etc/sysconfig/vncservers, such as:

VNCSERVERS="1:userjoe"
VNCSERVERARGS[1]="-geometry 1280x768 -depth 16"

2.  Make 'userjoe' have /bin/csh as shell


3.  start vncserver service:

sudo service vncserver start



Actual results:

Starting VNC server: 1:userjoe Invalid null command.
if: Expression Syntax.

Expected results:

Starting VNC server: 1:userjoe                             [  OK  ]

Additional info:

Just adding -s /bin/sh to the runuser call lets the runuser command complete successfully, but then SHELL is set incorrectly in the vnc session's environment.
Comment 1 John Hein 2013-11-15 04:22:56 UTC 
Created attachment 824289 [details]
let vncserver fail if there is a missing passwd file

Just run vncserver and let vncserver fail if there is a missing passwd file.
Comment 3 Tim Waugh 2013-11-18 12:34:41 UTC 

*** This bug has been marked as a duplicate of bug 949522 ***