Bug 1030802
| Summary: | ETPS/2 Elantech Touchpad click problems | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Victor Ion Munteanu <victor.munteanu> | ||||||||||||
| Component: | kernel | Assignee: | Josh Boyer <jwboyer> | ||||||||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||||||||
| Severity: | unspecified | Docs Contact: | |||||||||||||
| Priority: | unspecified | ||||||||||||||
| Version: | 19 | CC: | eldermarco, gansalmon, hdegoede, itamar, jonathan, kernel-maint, madhu.chinakonda, peter.hutterer, theo148, victor.munteanu | ||||||||||||
| Target Milestone: | --- | ||||||||||||||
| Target Release: | --- | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Whiteboard: | |||||||||||||||
| Fixed In Version: | kernel-3.12.5-302.fc20 | Doc Type: | Bug Fix | ||||||||||||
| Doc Text: | Story Points: | --- | |||||||||||||
| Clone Of: | Environment: | ||||||||||||||
| Last Closed: | 2013-12-21 02:13:40 UTC | Type: | Bug | ||||||||||||
| Regression: | --- | Mount Type: | --- | ||||||||||||
| Documentation: | --- | CRM: | |||||||||||||
| Verified Versions: | Category: | --- | |||||||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||||||
| Embargoed: | |||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Victor Ion Munteanu
2013-11-15 07:32:58 UTC
Hi Munteanu, Does your touchpad have separate physical buttons for the "mouse" buttons, or is it a touchpad which you press-down until you feel a click to do a button press (a so called clickpad) ? If it is a clickpad, have you tried different areas of the pad? Usually there is an area reserved for right clicks, and the rest registers as left clicks. It would also help to know which model laptop you have. If the problem is not solved by using certain areas of the touchpad to emulate specific button presses, we will need some recordings of the "raw" events generated by the touchpad to further debug this problem. In this case first of all do a "yum install evemu", and then follow the recording instructions here: http://who-t.blogspot.nl/2013/11/evtest-is-dead-long-live-evemu.html Note it is especially important that you also try playback and that the playback shows the problem. You can start xev in a terminal under X to make events visible. When you attach the recording, please also describe which button presses should be seen, as well as which presses you're actually seeing on playback, ie add something like this: Button pressed on touchpad; Button seen by X: Right Right Right Left Left Right Hi Hans,
I'm sorry for the late reply. The laptop model is Asus G750JX. The touchpad has two separate distinct buttons.
I've tried the evemu (according to the guide) but I get:
"error: this device is grabbed and I cannot record events"
As for xev, when i left click I get:
ButtonPress event, serial 36, synthetic NO, window 0x2e00001,
root 0x28a, subw 0x0, time 802957, (100,131), root:(102,254),
state 0x10, button 1, same_screen YES
ButtonRelease event, serial 36, synthetic NO, window 0x2e00001,
root 0x28a, subw 0x0, time 803154, (100,131), root:(102,254),
state 0x110, button 1, same_screen YES
But when I right click, xev registers nothing.
I will try to see how to make xorg not grabb the device to get you the raw data.
You can just VT-switch away, or run xinput --disable "device name". For something more permanent, drop this into your /etc/X11/xorg.conf.d directory: Section "InputClass" Identifier "Don't grab synaptics" MatchDriver "synaptics" Option "GrabEventDevice" "off" EndSection Hi Munteanu, To debug this further we really need some evemu recordings. As Peter said you can make them from a text console, this mean you won;t be able to look at xev at the same time, but that is not that important. Can you please make a recording of a left and right button press on a text console and attach those here? Thanks, Hans Created attachment 833060 [details]
evemu recording
Hi Hans and Peter, I've disabled it and was able to record (as can be seen in the attachment). Unfortunately the recording never registers the right click, only the left one (as can be seen in the recording). I'm not sure what to make of this, except that the driver support is flaky. Please note that it works fine under Windows. Best, Victor Thanks, This looks like it may be a kernel bug. Can you please do "dmesg > dmesg.log" in a terminal and the attach dmesg.log here? Regards, Hans Note to self, likely cause of this is: https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drivers/input/mouse/elantech.c?id=e3dde4fba94e0ba5e1fd79ea9e5389eea1f0cfec Need dmesg to confirm that this is a v4 model. I'm pretty sure I know how to fix this now, I don't need full dmesg, can you do: dmesg | grep elan In a terminal and paste the output here please ? Sorry for the late reply, was in meetings all day. Output as follows: [ 2.611317] psmouse serio4: elantech: assuming hardware version 4 (with firmware version 0x360f00) [ 2.625765] psmouse serio4: elantech: Synaptics capabilities query result 0x00, 0x16, 0x0c. Hope this helps. Created attachment 833171 [details]
Dmesg output
I've attached full dmesg just in case you need it.
(In reply to Munteanu Victor Ion from comment #10) > Sorry for the late reply, was in meetings all day. > > Output as follows: > > [ 2.611317] psmouse serio4: elantech: assuming hardware version 4 (with > firmware version 0x360f00) > [ 2.625765] psmouse serio4: elantech: Synaptics capabilities query result > 0x00, 0x16, 0x0c. > > Hope this helps. Excellent that confirms my suspicions and also matches wrt the undocumented bit I've found to differentiate between clickpads and devices with real hardware buttons. I'll whip up a kernel patch for this and build a test kernel for you. I don't know when I'll have time for this. Monday at the latest but hopefully sooner. Thanks for the quick reply. Please also note that my left click is behaving most of the time as left click (80%) and the remainder as right click, and I'm not sure what triggers the change in behaviour. (In reply to Munteanu Victor Ion from comment #13) > Thanks for the quick reply. Please also note that my left click is behaving > most of the time as left click (80%) and the remainder as right click, and > I'm not sure what triggers the change in behaviour. This is likely caused by you having a finger on the right bottom area of the touchpad, and since the driver thinks it is a clickpad (with a single button underneath the pad) it interprets clicks on that single button (your left button) with a finger in the bottom right area as a right click. The fix I've planned should also fix that. Created attachment 834347 [details]
PATCH: proper detect wether v3/v4 is a clickpad or not
Created attachment 834349 [details]
PATCH: elantech: add support for IC body v8
While fixing the elantech driver anyways lets also add support for IC body v8 (trivial patch).
Hi Munteanu, I've done a test kernel-build with the 2 attached patches, which should fix your problem, you can download it here: http://koji.fedoraproject.org/koji/taskinfo?taskID=6272001 Please don't wait too long with downloading, as it is a test build the buildsystem will remove it in a couple of days. Please let us know if this fixes your issue. Thanks, Hans Hi Hans, I've downloaded and tested the kernel and it works. The right click works, left click doesn't right click when finger is on bottom area. It's great! Thanks, Victor Created attachment 834680 [details]
PATCH v2: proper detect wether v3/v4 is a clickpad or not
New version of the patch fixing this, with some minor changes based on upstream review.
Josh, Can you add the 2 patches I've attached here to the next Fedora kernel-builds, and make bodhi close this bug when they hit stable? I can do it myself, but I've the feeling I would only get in your way wrt creating updates in bodhi, etc. Thanks & Regards, Hans (In reply to Hans de Goede from comment #20) > Josh, > > Can you add the 2 patches I've attached here to the next Fedora > kernel-builds, and make bodhi close this bug when they hit stable? > > I can do it myself, but I've the feeling I would only get in your way wrt > creating updates in bodhi, etc. > > Thanks & Regards, > > Hans Yes, but do you have a link to the upstream submission of them? That way I can put it in the patches and we know where they're headed and have an idea of when they'll be in Linus' tree. First patch submission is here: http://www.mail-archive.com/linux-input@vger.kernel.org/msg07220.html Second patch is already upstream since a few days: https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drivers/input/mouse/elantech.c?id=9cb80b965eaf7af1369f6e16f48a05fbaaccc021 Great. Thanks Hans. I'll get these in later today. Patches added. Thanks again. Thank you both for the help. I wish you guys handled the wireless part also, would speed up my bug report there also :) kernel-3.12.5-301.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/kernel-3.12.5-301.fc20 Package kernel-3.12.5-301.fc20: * should fix your issue, * was pushed to the Fedora 20 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing kernel-3.12.5-301.fc20' as soon as you are able to, then reboot. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2013-23445/kernel-3.12.5-301.fc20 then log in and leave karma (feedback). kernel-3.12.5-200.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/kernel-3.12.5-200.fc19 Package kernel-3.12.5-302.fc20: * should fix your issue, * was pushed to the Fedora 20 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing kernel-3.12.5-302.fc20' as soon as you are able to, then reboot. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2013-23445/kernel-3.12.5-302.fc20 then log in and leave karma (feedback). kernel-3.12.5-200.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report. kernel-3.12.5-302.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report. I think that there is an exception for Dell Vostro 5470. I opened a new bug here: https://bugzilla.redhat.com/show_bug.cgi?id=1103528 |