Bug 1031221

Summary:	[GSS] (6.2.x) LogContext's root logger is not created with a strong child hash map when strong=true
Product:	[JBoss] JBoss Enterprise Application Platform 6	Reporter:	Kyle Lape <klape>
Component:	Logging	Assignee:	James Perkins <jperkins>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Nikoleta Hlavickova <nziakova>
Severity:	unspecified	Docs Contact:	Russell Dickenson <rdickens>
Priority:	unspecified
Version:	6.2.0	CC:	bmaxwell, jperkins, marc.balsys, myarboro, pkremens, smumford
Target Milestone:	CR1
Target Release:	EAP 6.2.1
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:	In previous versions of JBoss EAP 6, it was found that loggers were sometimes garbage collected early resulting in loss of the loggers and configuration. For example, if a logger had an appender assigned, when the logger is garbage collected a new logger would have been created without the appender attached. In this release of the product, the map of loggers has been changed to use a strong reference rather than a weak reference. This causes the loggers not to get garbage collected and things to work as they should. As a result custom loggers are now honored as expected.	Story Points:	---
Clone Of:
Clones:	1052198 (view as bug list)		Environment:
Last Closed:	2014-02-24 20:15:42 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1052198
Bug Blocks:	1027004, 1031229

Description Kyle Lape 2013-11-15 22:58:50 UTC

When deploying an application in EAP 6 that has a log4j.xml that is deployed by the logging subsystem, it seems that the LogContext is somehow losing a reference to a custom logger, causing all configuration for that logger to be lost.

Given this configuration:

<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE log4j:configuration SYSTEM "log4j.dtd">
<log4j:configuration xmlns:log4j="http://jakarta.apache.org/log4j/" debug="true">
  <appender name="SAMPLE_APP" class="org.apache.log4j.RollingFileAppender">
    <param name="File" value="${jboss.server.log.dir}/SampleApp.log"/>
    <param name="MaxFileSize" value="2MB"/>
    <param name="MaxBackupIndex" value="5"/>
    <param name="Append" value="true"/>
    <layout class="org.apache.log4j.PatternLayout">
      <param name="ConversionPattern" value="%d %c [%t] %-5p - %m%n"/>
    </layout>
  </appender>
  <appender name="SAMPLE_APP_MDB" class="org.apache.log4j.RollingFileAppender">
    <param name="File" value="${jboss.server.log.dir}/SampleApp-MDB.log"/>
    <param name="MaxFileSize" value="2MB"/>
    <param name="MaxBackupIndex" value="5"/>
    <param name="Append" value="true"/>
    <layout class="org.apache.log4j.PatternLayout">
      <param name="ConversionPattern" value="%d %c [%t] %-5p - %m%n"/>
    </layout>
  </appender>
  <logger name="com.redhat" additivity="false">
    <level value="TRACE"/>
    <appender-ref ref="SAMPLE_APP_MDB"/>
  </logger>
  <root>
    <priority value="TRACE"/>
    <appender-ref ref="SAMPLE_APP"/>
  </root>
</log4j:configuration>

Every log message ends up in {{SAMPLE_APP}}, regardless of which logger was used.  One finalizer message is also printed to the log:

11:33:00,110 INFO  [stdout] (Finalizer) log4j: Finalizing appender named [SAMPLE_APP_MDB].

Comment 2 JBoss JIRA Server 2013-12-12 18:48:55 UTC

James Perkins <jperkins> updated the status of jira LOGMGR-89 to Resolved

Comment 4 Scott Mumford 2014-01-21 03:26:59 UTC

Setting flag for inclusion in 6.2.1 release notes.

Comment 5 Scott Mumford 2014-01-24 01:20:12 UTC

Set 'Version' field to ensure this ticket appears in documentation effort dashboards.

Comment 6 Scott Mumford 2014-01-28 00:31:34 UTC

Hi James.

Can you provide a few details in the Doc Text box above. I took a shot at the 'Consequence' and 'Result' fields, as best I could with what I can grok.

Could you fill in the gaps and straighten out my attempts if I've misunderstood? 

Thanks in advance.

Comment 7 James Perkins 2014-01-28 01:06:36 UTC

I updated it the best I could think of. Just as a general note, if it matters, this only affected log4j.

Comment 8 Scott Mumford 2014-01-28 03:54:25 UTC

Thanks James. Very much appreciated.

Editing doc text for publication and marking for inclusion in document.

Comment 9 Petr Kremensky 2014-01-31 08:18:26 UTC

Verified on EAP 6.2.1 CP CR3