Bug 1031299

Summary:	displays duplicate for each btrfs device with btrfs filesystem show
Product:	[Fedora] Fedora	Reporter:	Chris Murphy <bugzilla>
Component:	btrfs-progs	Assignee:	Josef Bacik <josef>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	20	CC:	awilliam, bugzilla, dlehman, eguan, esandeen, gczarcinski, josef, mmahut
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	RejectedFreezeException
Fixed In Version:	btrfs-progs-3.12-1.fc20	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-12-14 02:44:41 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Chris Murphy 2013-11-16 16:03:37 UTC

Description of problem: 

Duplicate results are produced when using btrfs filesystem show.


Version-Release number of selected component (if applicable):

btrfs-progs-0.20.rc1.20131114git9f0c53f-1.fc20.x86_64  


How reproducible:

Always


Steps to Reproduce:

1. Format a partition btrfs.
2. btrfs fi show

Actual results:

Label: fedora  uuid: 8acbdc01-bcda-4d0f-bc89-bb7414b9a11f
	Total devices 1 FS bytes used 33.95GiB
	devid    1 size 292.97GiB used 37.04GiB path /dev/sda6

Label: fedora  uuid: 8acbdc01-bcda-4d0f-bc89-bb7414b9a11f
	Total devices 1 FS bytes used 33.95GiB
	devid    1 size 292.97GiB used 37.04GiB path /dev/sda6

Expected results:

Just one of those results.


Additional info:

Does not occur with btrfs-progs-0.20.rc1.20130917git194aa4a-1.fc20.x86_64.

Comment 1 Gene Czarcinski 2013-11-16 16:43:50 UTC

And if you have a couple of multi-device btrfs volumes defined it gets really verbose with the repetition.  For example, a system with a two SSD btrfs volume and a two USB disk btrfs volume produced three outputs for the SSD volume and six for the USB disks volume.

Comment 2 Chris Murphy 2013-11-22 03:24:41 UTC

Fix upstream available. http://www.mail-archive.com/linux-btrfs@vger.kernel.org/msg28960.html

Comment 3 Fedora Blocker Bugs Application 2013-11-22 03:29:42 UTC

Proposed as a Freeze Exception for 20-final by Fedora user chrismurphy using the blocker tracking app because:

 This is a cosmetic bug, but it would be nice if F20 live media included a fix so that using live media to troubleshoot btrfs volumes is less cluttered than with the bug.

Comment 4 Chris Murphy 2013-11-26 20:21:53 UTC

The (somewhat obscure) workaround is to use -d to avoid duplicates showing. And this bug is fixed in btrfs-progs 3.12. So I think the freezeexception is moot since there's unlikely to be an intermediate fix for release.

Comment 5 Eric Sandeen 2013-11-26 20:47:24 UTC

Ah, whoops, I didn't add this bug to the 3.12 update.  Will do.

Comment 6 Fedora Update System 2013-11-26 20:53:34 UTC

btrfs-progs-3.12-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/FEDORA-2013-22152/btrfs-progs-3.12-1.fc20

Comment 7 Adam Williamson 2013-11-26 21:21:24 UTC

so, dlehman and cmurf were both somewhat worried about changing btrfs-progs post-freeze when I asked about it in general terms. CCing dlehman: does your opinion change with this bug? or would you still prefer to stick with what we have in stable and in tc1/tc2 so far?

Comment 8 Chris Murphy 2013-11-26 21:40:17 UTC

btrfs-progs-0.20.rc1.20130917git194aa4a-1.fc20 = TC1/TC2

btrfs-progs-0.20.rc1.20131114git9f0c53f-1.fc20 = should be in TC3 as it went stable before freeze. The biggest change I can think of here is mkfs now uses 16KB leafsize/nodesize, but also causes this bug.

btrfs-progs 3.12 fixes this bug, but is intended for kernel 3.12 which isn't going to ship with F20.

Comment 9 Adam Williamson 2013-11-26 21:42:10 UTC

ah, i didn't notice that we already have a new build for tc3, thanks for catching that. guess we'd best be on the lookout for issues.

Comment 10 Chris Murphy 2013-11-26 21:52:09 UTC

FWIW, the leafsize/nodesize change doesn't cause this bug, I meant that this bug was introduced with the listed btrfs-progs version.

I've been using the 1114 progs with anaconda for almost 2 weeks with no apparent problems.

Comment 11 Eric Sandeen 2013-11-26 21:53:04 UTC

FWIW, I don' care if this ships w/ F20 or not.  ;)  The release came out, I built it & pushed it - you all can decide what to do with it.  I won't complain either way.

Comment 12 David Lehman 2013-11-26 21:57:25 UTC

I am fine with it going in as long as it doesn't change something that generates installer bugs, and I don't have time to verify that it doesn't break anything during OS installation.

Comment 13 Adam Williamson 2013-11-27 19:06:46 UTC

Discussed at 2013-11-27 freeze exception review meeting: http://meetbot.fedoraproject.org/fedora-blocker-review/2013-11-27/f20-blocker-review-3.2013-11-27-17.01.log.txt . This was rejected as a freeze exception issue, as the bug is cosmetic and not a huge problem, and can be fixed with a post-release update. It's not worth introducing change to a critical component for the installer just to fix this. If there's any more pressing reason to take 3.12 into GA, we can consider that, please nominate an appropriate bug as blocker/FE.

Comment 14 Fedora Update System 2013-12-14 02:44:41 UTC

btrfs-progs-3.12-1.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.