Bug 1032978

Summary: When plugging in an external screen, brightness defaults to the lowest possible setting
Product: [Fedora] Fedora Reporter: Elad Alfassa <elad>
Component: xorg-x11-drv-intelAssignee: Hans de Goede <hdegoede>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 20CC: ajax, bblaskov, eischmann, elad, gansalmon, hdegoede, itamar, jik, jonathan, kernel-maint, madhu.chinakonda, nathanel.titane, nicolas, xgl-maint
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: xorg-x11-drv-intel-2.21.15-7.fc20 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-06-19 23:00:03 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
journalctl concerning thinkpad_acpi driver
none
restart Xorg, plug HDMI, wait for appr. 30 sec., suspend/resume (close/open lid)
none
Xorg.0.log.2
none
Xorg.0.log.3 none

Description Elad Alfassa 2013-11-21 10:39:48 UTC
When plugging in an external screen, brightness of the laptop screen defaults to the lowest possible setting, which on Lenovo laptops means backlight turns off completely.

This shouldn't happen.

Comment 1 Nathanel Titane 2013-11-25 06:17:16 UTC
+1 for me using an Asus X75VD with HDMI out. When closing the lid and eventually opening it to resume activity, the system wakes adequately but does not reinstate previous brightness setting and defaults it to 0 on laptop display (no image whatsoever.)

Linux Mercury 3.11.8-300.fc20.x86_64 #1 SMP Wed Nov 13 16:34:27 UTC 2013 x86_64 x86_64 x86_64 GNU/Linux

Fedora 20 x86_64

Comment 2 Jonathan Kamens 2013-12-19 22:31:12 UTC
Seeing this with ThinkPad T420i. It wasn't happening in Fedora 19, just started yesterday when I upgraded to Fedora 20.

Comment 3 Justin M. Forbes 2014-02-24 14:03:20 UTC
*********** MASS BUG UPDATE **************

We apologize for the inconvenience.  There is a large number of bugs to go through and several of them have gone stale.  Due to this, we are doing a mass bug update across all of the Fedora 20 kernel bugs.

Fedora 20 has now been rebased to 3.13.4-200.fc20.  Please test this kernel update and let us know if you issue has been resolved or if it is still present with the newer kernel.

If you experience different issues, please open a new bug report for those.

Comment 4 Elad Alfassa 2014-02-24 14:05:19 UTC
Still a problem even with latest kernel.

Comment 5 Lucile Quirion 2014-04-03 19:30:09 UTC
Created attachment 882405 [details]
journalctl concerning thinkpad_acpi driver

+1 for me using an Thinkpad Twist (S230u)

When the external screen is plugged, brightness of the laptop screen defaults to 0.
Booting with the external screen plugged in causes the same problem.
Closing the lid and opening it again defaults laptop screen brightness to 0.

$ uname -sr
Linux 3.13.7-200.fc20.x86_64

$ cat /etc/fedora-release 
Fedora release 20 (Heisenbug)

$ journalctl -b | grep brightness
avr 03 09:37:09 localhost.localdomain kernel: thinkpad_acpi: Unsupported brightness interface, please contact ibm-acpi-devel.net
avr 03 09:37:09 localhost.localdomain kernel: thinkpad_acpi: This ThinkPad has standard ACPI backlight brightness control, supported by the ACPI video driver
avr 03 09:37:09 localhost.localdomain kernel: thinkpad_acpi: Disabling thinkpad-acpi brightness events by default...

Following some discussions in this mailing-list it seems the file incriminated is linux/drivers/gpu/drm/i915/intel_panel.c
Several commits have been applied to this file.

Any help to build and test the v3.14 i915 driver would be appreciated.

Comment 6 Lucile Quirion 2014-04-04 21:17:45 UTC
I traced access/write to /sys/class/backlight/intel_backlight/brightness with systemtap and plugged the external screen (HDMI). 

Xorg is the process accessing the file to write 0.

I have the following drivers installed:
$ rpm -qa | grep intel
xorg-x11-drv-intel-2.21.15-5.fc20.x86_64

I tested with default config (UXA) then SNA and evertime Xorg set brightness to 0.

Good luck

Comment 7 Elad Alfassa 2014-04-04 21:20:04 UTC
Moving this bug to xorg-x11-drv-intel

Comment 8 Nicolas Dufresne 2014-05-26 14:27:18 UTC
Same here, Thinkpad X230. At boot the backlight is set to 0, and after login same thing.

Comment 9 Hans de Goede 2014-06-02 13:34:26 UTC
Hi All,

I've just done a scratch build of the Fedora-20 intel driver with some debugging added to try and see
where the 0 it is allegedly writing to brightness is coming from.  You can find it here:
http://koji.fedoraproject.org/koji/taskinfo?taskID=6917469

Please install this, then do the following to kill your session (to restart X) :

sudo killall Xorg

Then plug in the hdmi cable, wait 30 seconds, do a suspend / resume, and collect the /var/log/Xorg.0.log file and attach it here.

Thanks,

Hans

Comment 10 Hans de Goede 2014-06-02 18:35:56 UTC
Also can you please try the latest 3.15 kernel? With some luck this has already been fixed, you cfan find the latest 3.15 kernel build for Fedora here:
http://koji.fedoraproject.org/koji/buildinfo?buildID=520926

Download the kernel-3.15...rpm for your architecture and then install it using:

sudo rpm -ivh kernel-3.15...rpm

Note when installing kernels it is important to rpm -i so that you keep your current kernel as a backup.

Comment 11 Lucile Quirion 2014-06-03 14:53:10 UTC
Created attachment 901818 [details]
restart Xorg, plug HDMI, wait for appr. 30 sec., suspend/resume (close/open lid)

Hi,

The latest 3.15 kernel does not resolve the problem.

The latest Intel drivers: xorg-x11-drv-intel-2.99.910-20.intel20141.x86_64 do not resolve the problem. (https://download.01.org/gfx/fedora/20/x86_64/)

However I did not had this problem with Ubuntu Saucy (2.99.904).

I did the manipulation with xorg-x11-drv-intel-2.21.15-6.fc20.hdg1032978.x86_64 installed (see attachment), and kernel 3.14:
restart Xorg (brightness ok)
plug HDMI (laptop brightness nok, external screen ok)
suspend/resume (laptop brightness nok, external screen ok)

Comment 12 Elad Alfassa 2014-06-05 08:52:37 UTC
Hi Hans.

I followed your instructions, but the log file is not being written to for some reason (and hasn't been written to in a while)

However, I did manage to extract some useful info from the systemd journal.
After pluging in the external screen, it was not detected. I ran xrandr in the terminal (twice. first time it did nothing, second time it detected the screen) and then got these in the log:

Jun 05 11:42:06 rincewind gdm-Xorg-:0[28225]: (II) intel(0): XRANDR backlight property get, active_level 1054, DPMS mode 0, returning 1054
Jun 05 11:42:06 rincewind gdm-Xorg-:0[28225]: (II) intel(0): XRANDR backlight property set to 1054, DPMS mode 0
Jun 05 11:42:06 rincewind gdm-Xorg-:0[28225]: (II) intel(0): resizing framebuffer to 3286x1080
Jun 05 11:42:06 rincewind gdm-Xorg-:0[28225]: (II) intel(0): switch to mode 1366x768 on pipe 0 using LVDS1, position (0, 0), rotation normal
Jun 05 11:42:06 rincewind gdm-Xorg-:0[28225]: (II) intel(0): switch to mode 1920x1080 on pipe 0 using HDMI2, position (1366, 0), rotation normal
Jun 05 11:42:07 rincewind gdm-Xorg-:0[28225]: (II) intel(0): DPMS off mode 3, saved backlight level 0
Jun 05 11:42:07 rincewind gdm-Xorg-:0[28225]: (II) intel(0): switch to mode 1366x768 on pipe 1 using LVDS1, position (0, 0), rotation normal
Jun 05 11:42:07 rincewind gdm-Xorg-:0[28225]: (II) intel(0): DPMS on mode 0, setting backlight to 0
Jun 05 11:42:07 rincewind gdm-Xorg-:0[28225]: (II) intel(0): XRANDR backlight property get, active_level 0, DPMS mode 0, returning 0
Jun 05 11:42:07 rincewind gdm-Xorg-:0[28225]: (II) intel(0): XRANDR backlight property set to 0, DPMS mode 0
Jun 05 11:42:07 rincewind gdm-Xorg-:0[28225]: (II) intel(0): XRANDR backlight property get, active_level 0, DPMS mode 0, returning 0
Jun 05 11:42:07 rincewind gdm-Xorg-:0[28225]: (II) intel(0): XRANDR backlight property set to 0, DPMS mode 0
Jun 05 11:42:07 rincewind gdm-Xorg-:0[28225]: (II) intel(0): XRANDR backlight property get, active_level 0, DPMS mode 0, returning 0
Jun 05 11:42:07 rincewind gdm-Xorg-:0[28225]: (II) intel(0): XRANDR backlight property set to 0, DPMS mode 0

Comment 13 Hans de Goede 2014-06-05 12:54:38 UTC
Hi,

I think I know what is causing this, here is a new (scratch) xorg-x11-drv-intel package, which should fix this:

http://koji.fedoraproject.org/koji/taskinfo?taskID=6926499

Please give this a try without using any special kernel commandline options, and let me know if it fixes things. Please also collect and attach Xorg.0.log again.

Thanks & Regards,

Hans

Comment 14 Lucile Quirion 2014-06-05 14:37:56 UTC
Created attachment 902564 [details]
Xorg.0.log.2

Hi Hans,

The driver v2 worked partially :
restart xorg (laptop brightness ok)
plug HDMI (laptop + external screen ok)
suspend/resume (laptop nok, external screen ok)

I've attached the resulting Xorg.0.log 

Thanks

Comment 15 Hans de Goede 2014-06-06 15:03:33 UTC
Hi,

(In reply to Lucile Quirion from comment #14)
> Created attachment 902564 [details]
> Xorg.0.log.2
> 
> Hi Hans,
> 
> The driver v2 worked partially :
> restart xorg (laptop brightness ok)
> plug HDMI (laptop + external screen ok)
> suspend/resume (laptop nok, external screen ok)
> 
> I've attached the resulting Xorg.0.log 

Thanks, I've done a new build with one more fix which should hopefully fix the last case your seeing where the screen stays black:

http://koji.fedoraproject.org/koji/taskinfo?taskID=6929186

Please give this a try without using any special kernel commandline options, and let me know if it fixes things. Please also collect and attach Xorg.0.log again.

Thanks & Regards,

Hans

Comment 16 Lucile Quirion 2014-06-06 18:02:35 UTC
Created attachment 902997 [details]
Xorg.0.log.3

Hi,

The last version of the driver fixes things for me.

Xorg.0.log.3 is the log for the following test: restart Xorg, plug HDMI, wait 30s, suspend/resume with the driver v3.

Thank you very much.

Comment 17 Elad Alfassa 2014-06-08 10:23:24 UTC
Hi,
I can confirm this build fixes the problem for me too.

I think it should be pushed to F20 updates now :)

Comment 18 Hans de Goede 2014-06-11 10:17:13 UTC
*** Bug 1090860 has been marked as a duplicate of this bug. ***

Comment 19 Hans de Goede 2014-06-13 13:20:21 UTC
Hi All,

Upstream has come up with a fix which in some ways is quite different, which I've backported to the intel driver version in F-20. Can you please give this build a try:

http://koji.fedoraproject.org/koji/taskinfo?taskID=7042962

Once I've confirm that the (backported) upstream commit also fixes the backlight issues people have reported, then I'll do an official build with these fixes in, and we can finally close this bug.

Thanks,

Hans

Comment 20 Jiri Eischmann 2014-06-16 12:09:55 UTC
Yes, I can confirm that the backlight doesn't default to 0 any more. Now it defaults to 100% which is not a complete fix, but definitely better than a blackscreen.

Comment 21 Fedora Update System 2014-06-18 13:48:41 UTC
xorg-x11-drv-intel-2.21.15-7.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/xorg-x11-drv-intel-2.21.15-7.fc20

Comment 22 Fedora Update System 2014-06-18 22:21:48 UTC
Package xorg-x11-drv-intel-2.21.15-7.fc20:
* should fix your issue,
* was pushed to the Fedora 20 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing xorg-x11-drv-intel-2.21.15-7.fc20'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2014-7476/xorg-x11-drv-intel-2.21.15-7.fc20
then log in and leave karma (feedback).

Comment 23 Fedora Update System 2014-06-19 23:00:03 UTC
xorg-x11-drv-intel-2.21.15-7.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.