Bug 1033144

Summary: Not able to override $MAVEN_ARGS values in JBoss EWS cartridge
Product: OpenShift Online Reporter: Nikhil Mone <nmone>
Component: ImageAssignee: Dan Mace <dmace>
Status: CLOSED CURRENTRELEASE QA Contact: libra bugs <libra-bugs>
Severity: medium Docs Contact:
Priority: medium    
Version: 2.xCC: bmeng, brice.vandeputte, nmone, xtian
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: All   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 1033146 (view as bug list) Environment:
Last Closed: 2014-01-30 00:50:31 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 1033146    
Attachments:
Description Flags
Comment none

Description Nikhil Mone 2013-11-21 15:42:08 UTC 
Description of problem: Not able to override $MAVEN_ARGS values in JBoss EWS cartridge. See below :

[1] https://github.com/openshift/origin-server/blob/master/cartridges/openshift-origin-cartridge-jbossews/bin/build

One needs to modify  :

export MAVEN_ARGS="clean package -Popenshift -DskipTests"

to 

if [ -z "$MAVEN_ARGS" ]; then
   export MAVEN_ARGS="clean package -Popenshift -DskipTests"
fi

Similar to JBoss EAP cartridge


Version-Release number of selected component (if applicable):


How reproducible:
Every time

Steps to Reproduce:
1. Create a JBoss EWS application
2. create an action hook to override $MAVEN_ARGS
3. git add > commit > push the application, you will see variable is not overridden. 

Actual results:

$MAVEN_ARGS value stays to default : "clean package -Popenshift -DskipTests"

Expected results:

Should be overridden with the values provided in action hook

Additional info:
Comment 1 Nikhil Mone 2013-11-21 16:52:47 UTC 
Sent a pull request : https://github.com/openshift/origin-server/pull/4218
Comment 2 Dan Mace 2013-11-22 15:01:23 UTC 
Good catch!

https://github.com/openshift/origin-server/pull/4225
Comment 3 openshift-github-bot 2013-11-22 16:31:20 UTC 
Commit pushed to master at https://github.com/openshift/origin-server

https://github.com/openshift/origin-server/commit/be5a392a0a4a17dc335f4a7dc57f01c579d56fb2
Bug 1033144: Allow MAVEN_ARGS overriding in jbossews builds
Comment 4 Qiushui Zhang 2013-11-25 11:13:56 UTC 
Created attachment 915811 [details]
Comment

(This comment was longer than 65,535 characters and has been moved to an attachment by Red Hat Bugzilla).