Bug 1033144 - Not able to override $MAVEN_ARGS values in JBoss EWS cartridge
Summary: Not able to override $MAVEN_ARGS values in JBoss EWS cartridge
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: OpenShift Online
Classification: Red Hat
Component: Image
Version: 2.x
Hardware: All
OS: All
medium
medium
Target Milestone: ---
: ---
Assignee: Dan Mace
QA Contact: libra bugs
URL:
Whiteboard:
Depends On:
Blocks: 1033146
TreeView+ depends on / blocked
 
Reported: 2013-11-21 15:42 UTC by Nikhil Mone
Modified: 2018-12-03 20:46 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
: 1033146 (view as bug list)
Environment:
Last Closed: 2014-01-30 00:50:31 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
Comment (81.88 KB, text/plain)
2013-11-25 11:13 UTC, Qiushui Zhang
no flags Details

Description Nikhil Mone 2013-11-21 15:42:08 UTC
Description of problem: Not able to override $MAVEN_ARGS values in JBoss EWS cartridge. See below :

[1] https://github.com/openshift/origin-server/blob/master/cartridges/openshift-origin-cartridge-jbossews/bin/build

One needs to modify  :

export MAVEN_ARGS="clean package -Popenshift -DskipTests"

to 

if [ -z "$MAVEN_ARGS" ]; then
   export MAVEN_ARGS="clean package -Popenshift -DskipTests"
fi

Similar to JBoss EAP cartridge


Version-Release number of selected component (if applicable):


How reproducible:
Every time

Steps to Reproduce:
1. Create a JBoss EWS application
2. create an action hook to override $MAVEN_ARGS
3. git add > commit > push the application, you will see variable is not overridden. 

Actual results:

$MAVEN_ARGS value stays to default : "clean package -Popenshift -DskipTests"

Expected results:

Should be overridden with the values provided in action hook

Additional info:

Comment 1 Nikhil Mone 2013-11-21 16:52:47 UTC
Sent a pull request : https://github.com/openshift/origin-server/pull/4218

Comment 2 Dan Mace 2013-11-22 15:01:23 UTC
Good catch!

https://github.com/openshift/origin-server/pull/4225

Comment 3 openshift-github-bot 2013-11-22 16:31:20 UTC
Commit pushed to master at https://github.com/openshift/origin-server

https://github.com/openshift/origin-server/commit/be5a392a0a4a17dc335f4a7dc57f01c579d56fb2
Bug 1033144: Allow MAVEN_ARGS overriding in jbossews builds

Comment 4 Qiushui Zhang 2013-11-25 11:13:56 UTC
Created attachment 915811 [details]
Comment

(This comment was longer than 65,535 characters and has been moved to an attachment by Red Hat Bugzilla).


Note You need to log in before you can comment on or make changes to this bug.