Bug 1037897
| Summary: | Review Request: python-fmn-lib - Internal API components and model for Fedora Notifications | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ralph Bean <rbean> |
| Component: | Package Review | Assignee: | Pierre-YvesChibon <pingou> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | package-review, pingou |
| Target Milestone: | --- | Flags: | pingou:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-01-22 14:55:49 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1037821 | ||
| Bug Blocks: | 1037898, 1037899 | ||
|
Description
Ralph Bean
2013-12-04 02:39:42 UTC
Spec is clean * License is clean and is LGPLv2+ * Builds fine on F-19 x86_64 * Content is clean * srpm sources: 716a59fd9efa07bb78b9124fa50cfef640c7422a fmn.lib-0.1.1.tar.gz * upstream sources: 716a59fd9efa07bb78b9124fa50cfef640c7422a fmn.lib-0.1.1.tar.gz * No bundling seen * rpmlint is almost clean: $ rpmlint python-fmn-lib-0.1.1-1.fc20.src.rpm python-fmn-lib-0.1.1-1.fc19.noarch.rpm python-fmn-lib.src: W: spelling-error %description -l en_US fedmsg -> feeding python-fmn-lib.noarch: W: spelling-error %description -l en_US fedmsg -> feeding python-fmn-lib.noarch: W: no-manual-page-for-binary fmn-createdb 2 packages and 0 specfiles checked; 0 errors, 3 warnings. And these warnings can be safely ignored Please note that only the lib/model.py file has a license header, the other files do not. The only thing annoying me is that packages do not seem to list a python-sqlalchemy0.8: https://apps.fedoraproject.org/packages/s/python-sqlalchemy Do you plan to ask for an EPEL6 branch? If not then the spec should be simplified otherwise the Requires and BuildRequires might been to be adjusted. (In reply to Pierre-YvesChibon from comment #1) > The only thing annoying me is that packages do not seem to list a > python-sqlalchemy0.8: > https://apps.fedoraproject.org/packages/s/python-sqlalchemy Hm.. its there. It must be a bug in the fedora-packages app: http://admin.fedoraproject.org/updates/python-sqlalchemy0.8 > Do you plan to ask for an EPEL6 branch? If not then the spec should be > simplified otherwise the Requires and BuildRequires might been to be > adjusted. I do plan do task for an epel6 branch for deployment to Fedora Infrastructure. ok, we're good to go then :) This package is APPROVED Thanks, Pierre! New Package SCM Request ======================= Package Name: python-fmn-lib Short Description: Internal API components and model for Fedora Notifications Owners: ralph Branches: f18 f19 f20 el6 InitialCC: Git done (by process-git-requests). python-fmn-lib-0.1.1-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/python-fmn-lib-0.1.1-1.fc20 python-fmn-lib-0.1.1-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/python-fmn-lib-0.1.1-1.fc19 python-fmn-lib-0.1.1-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/python-fmn-lib-0.1.1-1.el6 python-fmn-lib-0.1.1-1.el6 has been pushed to the Fedora EPEL 6 stable repository. python-fmn-lib-0.1.1-1.fc20 has been pushed to the Fedora 20 stable repository. python-fmn-lib-0.1.1-1.fc19 has been pushed to the Fedora 19 stable repository. Package Change Request ====================== Package Name: python-fmn-lib New Branches: epel7 Owners: ralph Git done (by process-git-requests). |