Spec URL: http://ralph.fedorapeople.org//python-fmn-web.spec SRPM URL: http://ralph.fedorapeople.org//python-fmn-web-0.1.3-1.fc20.src.rpm Description: fmn is a family of systems to manage end-user notifications triggered by fedmsg, the Fedora FEDerated MESsage bus. This module contains the frontend web application for Fedora Notifications.
FYI, buildroot overrides have been created for the new dependencies python-fmn-rules and python-fmn-lib
Spec is clean * License is clean and is LGPLv2+ * Builds fine on F-19 x86_64 * srpm sources: f44730fc5f25f9425f77b204d9ccbdf209edc4fc fmn.web-0.1.3.tar.gz * upstream sources: f44730fc5f25f9425f77b204d9ccbdf209edc4fc python-fmn-web-0.1.3-1.fc20.src/fmn.web-0.1.3.tar.gz * No bundling seen * rpmlint is almost clean: $ rpmlint python-fmn-web-0.1.3-1.fc20.src.rpm python-fmn-web-0.1.3-1.fc19.noarch.rpm python-fmn-web.src: W: spelling-error Summary(en_US) Frontend -> Fronted, Front end, Front-end python-fmn-web.src: W: spelling-error %description -l en_US fedmsg -> feeding python-fmn-web.src: W: spelling-error %description -l en_US frontend -> fronted, front end, front-end python-fmn-web.noarch: E: explicit-lib-dependency python-fmn-lib python-fmn-web.noarch: E: explicit-lib-dependency python-urllib3 python-fmn-web.noarch: W: spelling-error Summary(en_US) Frontend -> Fronted, Front end, Front-end python-fmn-web.noarch: W: spelling-error %description -l en_US fedmsg -> feeding python-fmn-web.noarch: W: spelling-error %description -l en_US frontend -> fronted, front end, front-end python-fmn-web.noarch: W: non-standard-uid /usr/share/fmn.web/fmn.web.wsgi fmn.web python-fmn-web.noarch: E: script-without-shebang /usr/share/fmn.web/fmn.web.wsgi python-fmn-web.noarch: W: non-standard-uid /usr/share/fmn.web fmn.web python-fmn-web.noarch: W: non-standard-uid /usr/share/fmn.web/static fmn.web python-fmn-web.noarch: E: non-standard-dir-perm /usr/share/fmn.web/static 0644L 2 packages and 0 specfiles checked; 4 errors, 9 warnings. There are a couple of things I do not like here: - the apache configuration file is active - the wsgi file is active I would recommand providing 'sample' file, so basically the same files but with everything commented out. I do not think it is a good idea if people install fmn.web and it starts working w/o any action from them. This might results in security issues of people running web server without having realized it. This would fix 2 of the issues detected by rpmlint. The static content is not changed by the UI, thus I do not think you need to have fmn.web owning the /usr/share/fmn.web directory. If you do, then you probably should create the user properly: http://fedoraproject.org/wiki/Packaging:Guidelines#Users_and_Groups
Updated by removing the user %attr directive and by disabling the apache config by default. Spec URL: http://ralph.fedorapeople.org//python-fmn-web.spec SRPM URL: http://ralph.fedorapeople.org//python-fmn-web-0.1.4-1.fc20.src.rpm
rpmlint still has two errors (and still the same warnings): python-fmn-web.noarch: E: script-without-shebang /usr/share/fmn.web/fmn.web.wsgi python-fmn-web.noarch: E: non-standard-dir-perm /usr/share/fmn.web/static 0644L since the wsgi file is meant to be run by mod_wsgi, having no shebang is fine but the file could also just be chmod -x since it is not meant to be run directly (but called by apache). For the directory I think it's fine. So please fix the wsgi file before import but as they are now, these are not blockers to me. This package is APPROVED.
Thanks Pierre! Updated by making the wsgi file non-executable: Spec URL: http://ralph.fedorapeople.org//python-fmn-web.spec SRPM URL: http://ralph.fedorapeople.org//python-fmn-web-0.1.4-2.fc20.src.rpm
Thanks for fixing the wsgi :)
New Package SCM Request ======================= Package Name: python-fmn-web Short Description: Frontend Web Application for Fedora Notifications Owners: ralph Branches: f19 f20 el6 InitialCC:
Git done (by process-git-requests).
python-fmn-web-0.1.4-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/python-fmn-web-0.1.4-2.fc20
python-fmn-web-0.1.4-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/python-fmn-web-0.1.4-2.fc19
python-fmn-web-0.1.4-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/python-fmn-web-0.1.4-2.el6
python-fmn-web-0.1.4-2.el6 has been pushed to the Fedora EPEL 6 stable repository.
python-fmn-web-0.1.4-2.fc20 has been pushed to the Fedora 20 stable repository.
python-fmn-web-0.1.4-2.fc19 has been pushed to the Fedora 19 stable repository.
Package Change Request ====================== Package Name: python-fmn-web New Branches: epel7 Owners: ralph