| Summary: | Work with GPG signed git commits | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ankur Sinha (FranciscoD) <sanjay.ankur> |
| Component: | GitPython | Assignee: | Dennis Gilmore <dennis> |
| Status: | CLOSED DUPLICATE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | dennis, ignatenko |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-12-04 05:26:34 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
*** This bug has been marked as a duplicate of bug 1010706 *** |
Hi, GitPython doesn't work with GPG signed git commits. It errors out: remote: Traceback (most recent call last): remote: File "./hooks/post-receive-chained.d/post-receive-fedmsg", line 46, in <module> remote: commits = map(_build_commit, lines) remote: File "./hooks/post-receive-chained.d/post-receive-fedmsg", line 31, in _build_commit remote: name=commit.author.name, remote: File "/usr/lib64/python2.6/site-packages/gitdb/util.py", line 238, in __getattr__ remote: self._set_cache_(attr) remote: File "/usr/lib/python2.6/site-packages/git/objects/commit.py", line 132, in _set_cache_ remote: self._deserialize(StringIO(stream.read())) remote: File "/usr/lib/python2.6/site-packages/git/objects/commit.py", line 443, in _deserialize remote: self.author.name = self.author.name.decode(self.encoding) remote: LookupError: unknown encoding: -----BEGIN PGP SIGNATURE----- There's a pull request open at upstream's github instance, but since upstream is unresponsive, it hasn't been accepted yet. https://github.com/gitpython-developers/GitPython/pull/124 Unfortunately, master and the 0.3 branch are quite different and seem to be developed in parallel, so a patch isn't very simple to extract from the repository. Commit 62ecd6c is the latest commit with the gpg fix: https://github.com/sugi/GitPython/tree/gpg-sig-support It's 2 commits ahead of master. Thanks, Warm regards, Ankur