Bug 1010706 - [PATCH] Work with GPG signed git commits
Summary: [PATCH] Work with GPG signed git commits
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: GitPython
Version: rawhide
Hardware: All
OS: Linux
urgent
urgent
Target Milestone: ---
Assignee: Dennis Gilmore
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 1037922 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-09-22 17:06 UTC by Igor Gnatenko
Modified: 2013-12-30 05:05 UTC (History)
3 users (show)

Fixed In Version: GitPython-0.3.2-0.6.RC1.fc19
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-12-17 19:07:01 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Proposed patch for master branch (4.99 KB, patch)
2013-09-22 17:06 UTC, Igor Gnatenko
no flags Details | Diff
0001-Fix-crashing-w-LookupError-unknown-encoding-object-a.patch (5.05 KB, patch)
2013-09-28 18:39 UTC, Igor Gnatenko
no flags Details | Diff
0001-Fix-crashing-w-LookupError-unknown-encoding-object-a.patch (5.03 KB, patch)
2013-09-28 18:45 UTC, Igor Gnatenko
no flags Details | Diff
0001-Fix-crashing-w-LookupError-unknown-encoding-object-a.patch (10.20 KB, patch)
2013-10-07 06:59 UTC, Igor Gnatenko
no flags Details | Diff

Description Igor Gnatenko 2013-09-22 17:06:24 UTC
Created attachment 801249 [details]
Proposed patch for master branch

I want to add patch[0] as downstream..

$ ../kernel-package/kernel-package.py 
Traceback (most recent call last):
  File "../kernel-package/kernel-package.py", line 338, in <module>
    main()
  File "../kernel-package/kernel-package.py", line 326, in main
    options = Options(WORK_DIR)
  File "../kernel-package/kernel-package.py", line 60, in __init__
    self.author = self.hcommit.author
  File "/usr/lib64/python2.7/site-packages/gitdb/util.py", line 238, in __getattr__
    self._set_cache_(attr)
  File "/usr/lib/python2.7/site-packages/git/objects/commit.py", line 132, in _set_cache_
    self._deserialize(StringIO(stream.read()))
  File "/usr/lib/python2.7/site-packages/git/objects/commit.py", line 443, in _deserialize
    self.author.name = self.author.name.decode(self.encoding) 
LookupError: unknown encoding: object a0f6ed8ebe4f6d494ef70f67d4c0c153cbf59577


[0]https://github.com/gitpython-developers/GitPython/pull/57

Comment 1 Igor Gnatenko 2013-09-28 18:39:00 UTC
Created attachment 804474 [details]
0001-Fix-crashing-w-LookupError-unknown-encoding-object-a.patch

Updated patch

Comment 2 Igor Gnatenko 2013-09-28 18:45:29 UTC
Created attachment 804475 [details]
0001-Fix-crashing-w-LookupError-unknown-encoding-object-a.patch

Comment 3 Igor Gnatenko 2013-10-07 06:59:48 UTC
Created attachment 808732 [details]
0001-Fix-crashing-w-LookupError-unknown-encoding-object-a.patch

Updated fix w/ tests

Comment 5 Igor Gnatenko 2013-12-04 05:26:34 UTC
*** Bug 1037922 has been marked as a duplicate of this bug. ***

Comment 6 Ankur Sinha (FranciscoD) 2013-12-04 09:17:53 UTC
Igor, can you make the summary more descriptive so the maintainer will know what it's about? It isn't very clear what the issue here is too. Is this about it not taking gpg signed commits, since you closed that bug as a dup?

Comment 7 Igor Gnatenko 2013-12-04 12:55:45 UTC
Sure ;)

Comment 8 Fedora Update System 2013-12-07 21:58:21 UTC
GitPython-0.3.2-0.6.RC1.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/GitPython-0.3.2-0.6.RC1.el6

Comment 9 Fedora Update System 2013-12-07 21:59:35 UTC
GitPython-0.3.2-0.6.RC1.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/GitPython-0.3.2-0.6.RC1.fc19

Comment 10 Fedora Update System 2013-12-07 22:00:23 UTC
GitPython-0.3.2-0.6.RC1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/GitPython-0.3.2-0.6.RC1.fc20

Comment 11 Fedora Update System 2013-12-07 22:06:22 UTC
GitPython-0.3.2-0.6.RC1.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/GitPython-0.3.2-0.6.RC1.fc18

Comment 12 Fedora Update System 2013-12-08 17:49:38 UTC
Package GitPython-0.3.2-0.6.RC1.fc20:
* should fix your issue,
* was pushed to the Fedora 20 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing GitPython-0.3.2-0.6.RC1.fc20'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2013-22972/GitPython-0.3.2-0.6.RC1.fc20
then log in and leave karma (feedback).

Comment 13 Fedora Update System 2013-12-17 19:07:01 UTC
GitPython-0.3.2-0.6.RC1.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 14 Fedora Update System 2013-12-29 19:02:27 UTC
GitPython-0.3.2-0.6.RC1.el6 has been pushed to the Fedora EPEL 6 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 15 Fedora Update System 2013-12-30 05:01:21 UTC
GitPython-0.3.2-0.6.RC1.fc18 has been pushed to the Fedora 18 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 16 Fedora Update System 2013-12-30 05:05:26 UTC
GitPython-0.3.2-0.6.RC1.fc19 has been pushed to the Fedora 19 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.