Bug 1038128

Summary: Review Request: libeot - a library for parsing Embedded OpenType font files
Product: [Fedora] Fedora Reporter: David Tardon <dtardon>
Component: Package ReviewAssignee: Parag AN(पराग) <panemade>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: dtardon, i18n-bugs, package-review, panemade, tcallawa
Target Milestone: ---Flags: panemade: fedora-review+
gwync: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-12-12 16:25:19 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description David Tardon 2013-12-04 13:31:18 UTC 
Spec URL: http://dtardon.fedorapeople.org/rpm/libeot.spec
SRPM URL: http://dtardon.fedorapeople.org/rpm/libeot-0.01-1.fc21.src.rpm
Description: 
%{name} is a library for parsing Embedded OpenType files (Microsoft embedded font "standard") and converting them to other formats.

Fedora Account System Username: dtardon
Comment 1 David Tardon 2013-12-04 13:33:04 UTC 
Because of https://raw.github.com/umanwizard/libeot/master/PATENTS , I think this needs approval from Fedora Legal.
Comment 2 Tom "spot" Callaway 2013-12-10 15:21:57 UTC 
After review, libeot is cleared for inclusion in Fedora. Lifting FE-Legal.
Comment 3 Parag AN(पराग) 2013-12-10 16:32:08 UTC 
Review:
+ mock build for rawhide is successful

+ rpmlint on generated rpms 
libeot-devel.x86_64: W: no-documentation
libeot-tools.x86_64: W: no-documentation
libeot-tools.x86_64: W: no-manual-page-for-binary eot2ttf
5 packages and 0 specfiles checked; 0 errors, 3 warnings.

+ source verified with upstream as sha256sum
srpm tarball     : cf5091fa8e7dcdbe667335eb90a2cfdd0a3fe8f8c7c8d1ece44d9d055736a06a
upstream tarball : cf5091fa8e7dcdbe667335eb90a2cfdd0a3fe8f8c7c8d1ece44d9d055736a06a

+ License is valid and included in LICENSE file


suggestion:
1) header file timestamp can be preserved if used 
make install DESTDIR=%{buildroot} INSTALL="install -p"

2) build.log showing
configure: WARNING: unrecognized options: --disable-werror

so remove that option to ./configure
APPROVED.
Comment 4 David Tardon 2013-12-12 12:26:29 UTC 
New Package SCM Request
=======================
Package Name: libeot
Short Description: A library for parsing Embedded OpenType font files
Owners: caolanm dtardon
Branches: f20
InitialCC:
Comment 5 Gwyn Ciesla 2013-12-12 13:40:56 UTC 
Git done (by process-git-requests).