Bug 1038128 - Review Request: libeot - a library for parsing Embedded OpenType font files
Summary: Review Request: libeot - a library for parsing Embedded OpenType font files
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-12-04 13:31 UTC by David Tardon
Modified: 2013-12-12 16:25 UTC (History)
5 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2013-12-12 16:25:19 UTC
Type: ---
Embargoed:
panemade: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description David Tardon 2013-12-04 13:31:18 UTC
Spec URL: http://dtardon.fedorapeople.org/rpm/libeot.spec
SRPM URL: http://dtardon.fedorapeople.org/rpm/libeot-0.01-1.fc21.src.rpm
Description: 
%{name} is a library for parsing Embedded OpenType files (Microsoft embedded font "standard") and converting them to other formats.

Fedora Account System Username: dtardon

Comment 1 David Tardon 2013-12-04 13:33:04 UTC
Because of https://raw.github.com/umanwizard/libeot/master/PATENTS , I think this needs approval from Fedora Legal.

Comment 2 Tom "spot" Callaway 2013-12-10 15:21:57 UTC
After review, libeot is cleared for inclusion in Fedora. Lifting FE-Legal.

Comment 3 Parag AN(पराग) 2013-12-10 16:32:08 UTC
Review:
+ mock build for rawhide is successful

+ rpmlint on generated rpms 
libeot-devel.x86_64: W: no-documentation
libeot-tools.x86_64: W: no-documentation
libeot-tools.x86_64: W: no-manual-page-for-binary eot2ttf
5 packages and 0 specfiles checked; 0 errors, 3 warnings.

+ source verified with upstream as sha256sum
srpm tarball     : cf5091fa8e7dcdbe667335eb90a2cfdd0a3fe8f8c7c8d1ece44d9d055736a06a
upstream tarball : cf5091fa8e7dcdbe667335eb90a2cfdd0a3fe8f8c7c8d1ece44d9d055736a06a

+ License is valid and included in LICENSE file


suggestion:
1) header file timestamp can be preserved if used 
make install DESTDIR=%{buildroot} INSTALL="install -p"

2) build.log showing
configure: WARNING: unrecognized options: --disable-werror

so remove that option to ./configure
APPROVED.

Comment 4 David Tardon 2013-12-12 12:26:29 UTC
New Package SCM Request
=======================
Package Name: libeot
Short Description: A library for parsing Embedded OpenType font files
Owners: caolanm dtardon
Branches: f20
InitialCC:

Comment 5 Gwyn Ciesla 2013-12-12 13:40:56 UTC
Git done (by process-git-requests).


Note You need to log in before you can comment on or make changes to this bug.