Bug 1038274
Summary: | Review Request: rubygem-liquid - A secure, non-evaling end user template engine with aesthetic markup | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Ken Dreyer <ktdreyer> |
Component: | Package Review | Assignee: | Mamoru TASAKA <mtasaka> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | package-review |
Target Milestone: | --- | Flags: | mtasaka:
fedora-review+
gwync: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | rubygem-liquid-3.0.0-2.fc21 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2015-01-17 05:47:04 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Ken Dreyer
2013-12-04 19:09:57 UTC
I've updated the package to the latest upstream release and the latest Fedora Ruby guidelines. * Wed Dec 10 2014 Ken Dreyer <ktdreyer> - 3.0.0-1 - Update to latest upstream release - Adjustments for https://fedoraproject.org/wiki/Changes/Ruby_2.1 - Use %%license tag - Unconditionally pass tests until rubygem-spy is available Exact changes in Git: https://fedorapeople.org/cgit/ktdreyer/public_git/rubygem-liquid.git/commit/?id=61b430b7489a46773b2927b540270ff7b2341906 Spec URL: https://ktdreyer.fedorapeople.org/reviews/rubygem-liquid.spec SRPM URL: https://ktdreyer.fedorapeople.org/reviews/rubygem-liquid-3.0.0-1.fc22.src.rpm F22 scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=8333800 Taking. I would appreciate it if you would review my review request (bug 1175601) Two comments * License - As lib/liquid/module_ex.rb is under Ruby, the License tag should be "MIT and Ruby". * Enabling tests - Would you actually execute test suite as much as possible, like below (for example)? mkdir spy touch spy/integration.rb ruby -I"lib:.:test" -e 'Dir.glob("./test/**/*_test.rb").each{|f| require f unless /context_unit_test/ =~ f }' Would you update this? (also I would appreciate it if you have time to review bug 1175601) That is a good idea with the spy dummy lib. Thanks for that. New version: * Wed Jan 07 2015 Ken Dreyer <ktdreyer> - 3.0.0-2 - Add "Ruby" to License tag (RHBZ #1038274) - Create a dummy "spy/integration" lib so we can run the tests during %%check (RHBZ #1038274) Exact change in Git: https://fedorapeople.org/cgit/ktdreyer/public_git/rubygem-liquid.git/commit/?id=517dd72445d2a32767661db7bbc62c5f9aa41ba6 Spec URL: https://ktdreyer.fedorapeople.org/reviews/rubygem-liquid.spec SPRM URL: https://ktdreyer.fedorapeople.org/reviews/rubygem-liquid-3.0.0-2.fc22.src.rpm Rawhide (F22) Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=8545110 Okay, approving. ------------------------------------------------ This package (rubygem-liquid) is APPROVED by mtasaka ------------------------------------------------ Thanks very much for the review! New Package SCM Request ======================= Package Name: rubygem-liquid Short A secure, non-evaling end user template engine with aesthetic markup Upstream URL: http://www.liquidmarkup.org Owners: ktdreyer Branches: f21 InitialCC: WARNING: No description provided. WARNING: Requested package name rubygem-liquid Short A secure, non-evaling end user template engine with aesthetic markup doesn't match bug summary rubygem-liquid New Package SCM Request ======================= Package Name: rubygem-liquid Short Description: A secure, non-evaling end user template engine with aesthetic markup Upstream URL: http://www.liquidmarkup.org Owners: ktdreyer Branches: f21 InitialCC: Git done (by process-git-requests). rubygem-liquid-3.0.0-2.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/rubygem-liquid-3.0.0-2.fc21 rubygem-liquid-3.0.0-2.fc21 has been pushed to the Fedora 21 testing repository. rubygem-liquid-3.0.0-2.fc21 has been pushed to the Fedora 21 stable repository. |