Bug 1038274 - Review Request: rubygem-liquid - A secure, non-evaling end user template engine with aesthetic markup
Summary: Review Request: rubygem-liquid - A secure, non-evaling end user template engi...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Mamoru TASAKA
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-12-04 19:09 UTC by Ken Dreyer
Modified: 2015-01-17 05:47 UTC (History)
1 user (show)

Fixed In Version: rubygem-liquid-3.0.0-2.fc21
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-01-17 05:47:04 UTC
Type: ---
Embargoed:
mtasaka: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Ken Dreyer 2013-12-04 19:09:57 UTC
Spec URL: http://ktdreyer.fedorapeople.org/reviews/rubygem-liquid.spec
SRPM URL: http://ktdreyer.fedorapeople.org/reviews/rubygem-liquid-2.6.0-1.fc21.src.rpm
Description: 
Liquid is a template engine which was written with very specific requirements:
* It has to have beautiful and simple markup. Template engines which don't
  produce good looking markup are no fun to use.
* It needs to be non evaling and secure. Liquid templates are made so that
  users can edit them. You don't want to run code on your server which your
  users wrote.
* It has to be stateless. Compile and render steps have to be separate so that
  the expensive parsing and compiling can be done once and later on you can
  just render it passing in a hash with local variables and objects.
Fedora Account System Username: ktdreyer

F21 scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6256972

Comment 1 Ken Dreyer 2014-12-10 02:53:53 UTC
I've updated the package to the latest upstream release and the latest Fedora Ruby guidelines.

* Wed Dec 10 2014 Ken Dreyer <ktdreyer> - 3.0.0-1
- Update to latest upstream release
- Adjustments for https://fedoraproject.org/wiki/Changes/Ruby_2.1
- Use %%license tag
- Unconditionally pass tests until rubygem-spy is available

Exact changes in Git: https://fedorapeople.org/cgit/ktdreyer/public_git/rubygem-liquid.git/commit/?id=61b430b7489a46773b2927b540270ff7b2341906

Spec URL: https://ktdreyer.fedorapeople.org/reviews/rubygem-liquid.spec
SRPM URL: https://ktdreyer.fedorapeople.org/reviews/rubygem-liquid-3.0.0-1.fc22.src.rpm

F22 scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=8333800

Comment 2 Mamoru TASAKA 2014-12-18 07:47:06 UTC
Taking.

I would appreciate it if you would review my review request (bug 1175601)

Comment 3 Mamoru TASAKA 2014-12-27 15:27:14 UTC
Two comments

* License
  - As lib/liquid/module_ex.rb is under Ruby,
    the License tag should be "MIT and Ruby".

* Enabling tests
  - Would you actually execute test suite as much
    as possible, like below (for example)?

mkdir spy
touch spy/integration.rb
ruby -I"lib:.:test" -e 'Dir.glob("./test/**/*_test.rb").each{|f| require f unless /context_unit_test/ =~ f }'

Comment 4 Mamoru TASAKA 2015-01-05 14:39:40 UTC
Would you update this? (also I would appreciate it if you have time to review bug 1175601)

Comment 5 Ken Dreyer 2015-01-07 03:32:55 UTC
That is a good idea with the spy dummy lib. Thanks for that.

New version:

* Wed Jan 07 2015 Ken Dreyer <ktdreyer> - 3.0.0-2
- Add "Ruby" to License tag (RHBZ #1038274)
- Create a dummy "spy/integration" lib so we can run the tests during %%check
  (RHBZ #1038274)

Exact change in Git: https://fedorapeople.org/cgit/ktdreyer/public_git/rubygem-liquid.git/commit/?id=517dd72445d2a32767661db7bbc62c5f9aa41ba6

Spec URL: https://ktdreyer.fedorapeople.org/reviews/rubygem-liquid.spec
SPRM URL: https://ktdreyer.fedorapeople.org/reviews/rubygem-liquid-3.0.0-2.fc22.src.rpm

Rawhide (F22) Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=8545110

Comment 6 Mamoru TASAKA 2015-01-08 15:23:21 UTC
Okay, approving.

------------------------------------------------
  This package (rubygem-liquid) is APPROVED
  by mtasaka
------------------------------------------------

Comment 7 Ken Dreyer 2015-01-08 15:55:39 UTC
Thanks very much for the review!

New Package SCM Request
=======================
Package Name: rubygem-liquid
Short A secure, non-evaling end user template engine with aesthetic markup
Upstream URL: http://www.liquidmarkup.org
Owners: ktdreyer
Branches: f21
InitialCC:

Comment 8 Gwyn Ciesla 2015-01-08 16:23:37 UTC
WARNING: No description provided.
WARNING: Requested package name rubygem-liquid Short A secure, non-evaling
end user template engine with aesthetic markup doesn't match bug summary
rubygem-liquid

Comment 9 Ken Dreyer 2015-01-08 17:30:00 UTC
New Package SCM Request
=======================
Package Name: rubygem-liquid
Short Description: A secure, non-evaling end user template engine with aesthetic markup
Upstream URL: http://www.liquidmarkup.org
Owners: ktdreyer
Branches: f21
InitialCC:

Comment 10 Gwyn Ciesla 2015-01-08 17:52:26 UTC
Git done (by process-git-requests).

Comment 11 Fedora Update System 2015-01-08 23:10:08 UTC
rubygem-liquid-3.0.0-2.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/rubygem-liquid-3.0.0-2.fc21

Comment 12 Fedora Update System 2015-01-09 11:53:42 UTC
rubygem-liquid-3.0.0-2.fc21 has been pushed to the Fedora 21 testing repository.

Comment 13 Fedora Update System 2015-01-17 05:47:04 UTC
rubygem-liquid-3.0.0-2.fc21 has been pushed to the Fedora 21 stable repository.


Note You need to log in before you can comment on or make changes to this bug.