Bug 1040452

Summary: 3rdparty/double-convertion is too old for AArch64
Product: [Fedora] Fedora Reporter: Marcin Juszkiewicz <mjuszkie>
Component: qt5-qtdeclarativeAssignee: Than Ngo <than>
Status: CLOSED DUPLICATE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: hobbes1069, jreznik, kevin, ltinkl, rdieter, rnovacek, than
Target Milestone: ---Keywords: Triaged
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-02-02 21:25:13 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
upstream (doube-convertion) patch to add AArch64 support
none
complete fix none

Description Marcin Juszkiewicz 2013-12-11 13:08:04 UTC 
Created attachment 835275 [details]
upstream (doube-convertion) patch to add AArch64 support

Description of problem:

DEBUG: ../3rdparty/masm/jit/../../../3rdparty/double-conversion/utils.h:77:2: error: #error Target architecture was not detected as supported by Double-Conversion.

Version-Release number of selected component (if applicable):

5.2.0-rc1

How reproducible:

just try to build on aarch64

Actual results:

DEBUG: ../3rdparty/masm/jit/../../../3rdparty/double-conversion/utils.h:77:2: error: #error Target architecture was not detected as supported by Double-Conversion.

Expected results:

package builds

Additional info:

upstream reported: https://bugreports.qt-project.org/browse/QTBUG-35528
Comment 1 Marcin Juszkiewicz 2013-12-16 09:31:12 UTC 
Real upstream issue was https://code.google.com/p/double-conversion/issues/detail?id=33 

They wrote patch with wrong definition name so build fails.
Comment 2 Marcin Juszkiewicz 2014-01-03 13:53:50 UTC 
https://code.google.com/p/double-conversion/source/detail?r=4e24bb31bcc76d6d218f3056b4c24a109d367561&name=branch_v2.0 is upstream/upstream fix.
Comment 3 Marcin Juszkiewicz 2014-01-03 14:26:30 UTC 
Created attachment 844961 [details]
complete fix

This patch adds both upstream changes which are required. The only difference between patches and upstream are path changes and Changelog part stripped off from second one.

With those changes it builds fine.
Comment 4 Rex Dieter 2014-02-02 21:25:13 UTC 

*** This bug has been marked as a duplicate of bug 1056051 ***